Rewrite Docs Generator from Python to Scala/Java #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamrecursion
suggested changes
May 10, 2021
lib/scala/docs-generator/src/main/scala/org/enso/DocsGeneratorMain.scala
Outdated
Show resolved
Hide resolved
lib/scala/docs-generator/src/main/scala/org/enso/DocsGeneratorMain.scala
Outdated
Show resolved
Hide resolved
lib/scala/docs-generator/src/main/scala/org/enso/docsgenerator/TreeOfCommonPrefixes.scala
Outdated
Show resolved
Hide resolved
lib/scala/docs-generator/src/main/scala/org/enso/docsgenerator/TreeOfCommonPrefixes.scala
Outdated
Show resolved
Hide resolved
...ax/specialization/shared/src/main/scala/org/enso/syntax/text/docparser/DocParserRunner.scala
Outdated
Show resolved
Hide resolved
...ax/specialization/shared/src/main/scala/org/enso/syntax/text/docparser/DocParserRunner.scala
Outdated
Show resolved
Hide resolved
...ax/specialization/shared/src/main/scala/org/enso/syntax/text/docparser/DocParserRunner.scala
Outdated
Show resolved
Hide resolved
iamrecursion
suggested changes
May 11, 2021
lib/scala/docs-generator/src/main/scala/org/enso/docs/generator/Main.scala
Outdated
Show resolved
Hide resolved
lib/scala/docs-generator/src/main/scala/org/enso/docs/generator/Main.scala
Outdated
Show resolved
Hide resolved
lib/scala/docs-generator/src/main/scala/org/enso/docs/generator/Main.scala
Outdated
Show resolved
Hide resolved
lib/scala/docs-generator/src/main/scala/org/enso/docs/generator/Main.scala
Outdated
Show resolved
Hide resolved
lib/scala/docs-generator/src/main/scala/org/enso/docs/generator/TreeOfCommonPrefixes.scala
Outdated
Show resolved
Hide resolved
...ax/specialization/shared/src/main/scala/org/enso/syntax/text/docparser/DocParserRunner.scala
Show resolved
Hide resolved
iamrecursion
approved these changes
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #1699
It generates HTML files for future use in IDE, as well as Js files with tree of contents and react elements for use on website.
Also, I've refactored a bit Doc Generator in syntax-specialization library. Just made it cleaner, no changes to functionality.
Important Notes
Checklist
Please include the following checklist in your PR: