Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do Errors Better #1734

Merged
merged 12 commits into from May 11, 2021
Merged

Do Errors Better #1734

merged 12 commits into from May 11, 2021

Conversation

iamrecursion
Copy link
Contributor

Pull Request Description

Enhances the way we do errors to be more informative to users. Also contains some misc-fixes and workarounds for the IDE.

Closes #1630.

Important Notes

These are breaking changes.

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@iamrecursion iamrecursion added Type: Enhancement --breaking Important: a change that will break a public API or user-facing behaviour p-highest Should be completed ASAP labels May 10, 2021
@iamrecursion iamrecursion requested a review from 4e6 May 10, 2021 12:53
@iamrecursion iamrecursion self-assigned this May 10, 2021
@iamrecursion iamrecursion changed the title Wip/ara/better errors Do Errors Better May 10, 2021
@iamrecursion iamrecursion marked this pull request as ready for review May 11, 2021 07:51
4e6
4e6 approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@4e6 4e6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, just a couple of typos

distribution/std-lib/Standard/src/Base/Data/Vector.enso Outdated Show resolved Hide resolved
distribution/std-lib/Standard/src/Base/Data/Vector.enso Outdated Show resolved Hide resolved
@iamrecursion iamrecursion merged commit c4c4836 into main May 11, 2021
@iamrecursion iamrecursion deleted the wip/ara/better-errors branch May 11, 2021 09:19
iamrecursion added a commit that referenced this pull request Jun 24, 2021
@iamrecursion
Improve error types in the standard library (#1734)
620c2eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4e6 4e6 4e6 approved these changes

@kustosz kustosz Awaiting requested review from kustosz

@radeusgd radeusgd Awaiting requested review from radeusgd

@wdanilo wdanilo Awaiting requested review from wdanilo

Assignees

@iamrecursion iamrecursion

Labels
--breaking Important: a change that will break a public API or user-facing behaviour p-highest Should be completed ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use More Descriptive Errors than Nothing
2 participants
@iamrecursion @4e6