Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Oneshot Visualization #1749

Merged
merged 5 commits into from May 21, 2021
Merged

Add Oneshot Visualization #1749

merged 5 commits into from May 21, 2021

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented May 21, 2021 •
edited

Pull Request Description

The first part of issue #1737, implementing a "one-shot-call" visualization.

Important Notes

⚠️ API changes.

Added executionContext/executeExpression request. It behaves exactly the same as executionContext/attachVisualisation with the only difference that the expression will be executed once.

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@4e6 4e6 added Type: Enhancement p-high Should be completed in the next sprint labels May 21, 2021
@4e6 4e6 self-assigned this May 21, 2021
iamrecursion
iamrecursion approved these changes May 21, 2021
View reviewed changes
Copy link
Contributor

@iamrecursion iamrecursion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may have missed it, but I'd like to see a check for the only-once property, even if the underlying value gets updated.

docs/language-server/protocol-language-server.md Outdated
@@ -2751,6 +2753,46 @@ Sent from the server to the client to inform about a status of execution.

None

### `executionContext/executeVisualisation`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not executionContext/executeExpression?

@iamrecursion iamrecursion merged commit f34f8be into main May 21, 2021
@iamrecursion iamrecursion deleted the wip/db/execute-visualization branch May 21, 2021 13:19
iamrecursion pushed a commit that referenced this pull request Jun 24, 2021
@4e6 @iamrecursion
Add evaluation for one-shot expressions (#1749)
1addb0f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamrecursion iamrecursion iamrecursion approved these changes

@kustosz kustosz Awaiting requested review from kustosz

@radeusgd radeusgd Awaiting requested review from radeusgd

Assignees

@4e6 4e6

Labels
p-high Should be completed in the next sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@4e6 @iamrecursion