Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for the file/checksum Endpoint #1787

Merged
merged 4 commits into from Jun 8, 2021
Merged

Add Support for the file/checksum Endpoint #1787

merged 4 commits into from Jun 8, 2021

Conversation

iamrecursion
Copy link
Contributor

Pull Request Description

Does what it says on the tin.

Important Notes

N/A

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@iamrecursion iamrecursion added Type: Enhancement p-highest Should be completed ASAP labels Jun 8, 2021
@iamrecursion iamrecursion requested a review from 4e6 June 8, 2021 12:03
@iamrecursion iamrecursion self-assigned this Jun 8, 2021
@iamrecursion iamrecursion marked this pull request as ready for review June 8, 2021 12:04
4e6
4e6 approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@4e6 4e6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, just some cleanup required

...rver/src/main/scala/org/enso/languageserver/protocol/binary/BinaryConnectionController.scala Outdated Show resolved Hide resolved
...e-server/src/main/scala/org/enso/languageserver/protocol/json/JsonConnectionController.scala Outdated Show resolved Hide resolved
engine/language-server/src/main/scala/org/enso/languageserver/filemanager/FileSystem.scala Outdated Show resolved Hide resolved
...-server/src/main/scala/org/enso/languageserver/requesthandler/file/ChecksumFileHandler.scala Outdated Show resolved Hide resolved
@iamrecursion iamrecursion changed the title Add Support for the file/checksum Endpoint. Add Support for the file/checksum Endpoint Jun 8, 2021
@iamrecursion iamrecursion merged commit 0b363e3 into main Jun 8, 2021
@iamrecursion iamrecursion deleted the wip/ara/streaming-files branch June 8, 2021 14:21
iamrecursion added a commit that referenced this pull request Jun 24, 2021
@iamrecursion
Add support for the file/checksum endpoint (#1787)
a111c2c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4e6 4e6 4e6 approved these changes

@kustosz kustosz Awaiting requested review from kustosz

@radeusgd radeusgd Awaiting requested review from radeusgd

Assignees

@iamrecursion iamrecursion

Labels
p-highest Should be completed ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iamrecursion @4e6