Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add File System Path to the Content Roots #1827

Merged
merged 4 commits into from
Jul 5, 2021
Merged

Add File System Path to the Content Roots #1827

merged 4 commits into from
Jul 5, 2021

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Jun 30, 2021 •
edited
Loading

Pull Request Description

As I forgot to include this in #1821, a separate PR that adds the absolute path so that the IDE can easily generate the File.read nodes.

Important Notes

  • The type ContentRoot included among others in the session/initProtocolConnection response has been changed, so it may be a breaking change for the IDE, because most types of roots no longer have the name field and the Root type has been renamed to FileSystemRoot.

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@radeusgd radeusgd self-assigned this Jun 30, 2021
@radeusgd radeusgd added Category: Backend p-high Should be completed in the next sprint labels Jun 30, 2021
@radeusgd radeusgd mentioned this pull request Jun 30, 2021
Closed
8 tasks
farmaazon
farmaazon reviewed Jul 2, 2021
View reviewed changes
Copy link
Contributor

@farmaazon farmaazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API update looks good to me.

@radeusgd radeusgd merged commit 8d71145 into main Jul 5, 2021
@radeusgd radeusgd deleted the wip/rw/add-content-root-path branch July 5, 2021 09:23
iamrecursion pushed a commit that referenced this pull request Jul 9, 2021
@radeusgd @iamrecursion
Add File System Path to the Content Roots (#1827)
ba741a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farmaazon farmaazon farmaazon left review comments

@iamrecursion iamrecursion iamrecursion approved these changes

@4e6 4e6 Awaiting requested review from 4e6

@kustosz kustosz Awaiting requested review from kustosz

Assignees

@radeusgd radeusgd

Labels
p-high Should be completed in the next sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@radeusgd @farmaazon @iamrecursion