Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Idleness Http Endpoint #1847

Merged
merged 11 commits into from Jul 12, 2021
Merged

Add Idleness Http Endpoint #1847

merged 11 commits into from Jul 12, 2021

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented Jul 9, 2021

Pull Request Description

close #1829

PR implements an GET / _idle request that returns a number of seconds the Language Server is idle (since the last request from IDE). The endpoint is required to implement auto shutdown feature in the cloud.

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@4e6 4e6 added Type: Enhancement p-high Should be completed in the next sprint labels Jul 9, 2021
@4e6 4e6 self-assigned this Jul 9, 2021
Copy link
Contributor

@iamrecursion iamrecursion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing documentation in the LS API docs.

RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
4e6 and others added 5 commits July 9, 2021 17:36
Co-authored-by: Ara Adkins <iamrecursion@users.noreply.github.com>
Co-authored-by: Ara Adkins <iamrecursion@users.noreply.github.com>
Copy link
Contributor

@iamrecursion iamrecursion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, comprehensive docs!

@iamrecursion
Copy link
Contributor

Only thing is that you forgot to add it to the README.md in the language-server directory.

@4e6 4e6 merged commit b3badf1 into main Jul 12, 2021
@4e6 4e6 deleted the wip/db/idleness branch July 12, 2021 13:53
iamrecursion pushed a commit that referenced this pull request Jul 15, 2021
Implement `GET / _idle` request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p-high Should be completed in the next sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Idleness Request
2 participants