Fix Imports When Attaching Visualization #1857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeusgd
commented
Jul 13, 2021
| @@ -129,7 +129,10 @@ class UpsertVisualisationJob( | |||
| moduleName: String, | |||
| expression: String | |||
| )(implicit ctx: RuntimeContext): Either[EvalFailure, AnyRef] = { | |||
| val maybeModule = ctx.executionService.findModule(moduleName) | |||
| val context = ctx.executionService.getContext | |||
| // TODO [RW] more specific error when the module cannot be installed | |||
There was a problem hiding this comment.
Returning more specific errors would require altering the protocol which is out of scope of this quick fix.
I think that for now the ModuleNotFound should be enough as it is correct - the module could not be found, it is just not as specific (whether it could not be resolved or the download failed etc.). I suggest to add this later on.
There was a problem hiding this comment.
Please file an issue for this.
radeusgd
commented
Jul 13, 2021
.../runtime/src/test/scala/org/enso/interpreter/test/instrument/RuntimeVisualisationsTest.scala
Show resolved
Hide resolved
iamrecursion
approved these changes
Jul 14, 2021
| @@ -129,7 +129,10 @@ class UpsertVisualisationJob( | |||
| moduleName: String, | |||
| expression: String | |||
| )(implicit ctx: RuntimeContext): Either[EvalFailure, AnyRef] = { | |||
| val maybeModule = ctx.executionService.findModule(moduleName) | |||
| val context = ctx.executionService.getContext | |||
| // TODO [RW] more specific error when the module cannot be installed | |||
There was a problem hiding this comment.
Please file an issue for this.
.../runtime/src/test/scala/org/enso/interpreter/test/instrument/RuntimeVisualisationsTest.scala
Show resolved
Hide resolved
4e6
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes a bug introduced by new library logic - as we now only load the libraries on-demand, the
Standard.Visualizationlibrary was not preloaded and the attach visualization command did not try to preload it.Now, when the visualization is attached, it ensures that its module is preloaded.
Important Notes
Checklist
Please include the following checklist in your PR: