Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "Library Publishing MVP (#1898)"" #1933

Merged
merged 3 commits into from
Aug 9, 2021
Merged

Revert "Revert "Library Publishing MVP (#1898)"" #1933

merged 3 commits into from
Aug 9, 2021

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Aug 9, 2021 •
edited

Pull Request Description

Reintroduces the library publishing logic from #1898 that was later reverted.

It turns out this was not the cause of the nightly build failures, so it can be reintroduced.

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@radeusgd radeusgd self-assigned this Aug 9, 2021
@radeusgd radeusgd added Category: Backend -tooling Category: tooling p-high Should be completed in the next sprint labels Aug 9, 2021
@radeusgd radeusgd merged commit 31167fd into main Aug 9, 2021
@radeusgd radeusgd deleted the wip/rw/reintroduce-lib-publishing branch August 9, 2021 14:00
iamrecursion pushed a commit that referenced this pull request Aug 13, 2021
@radeusgd @iamrecursion
Revert "Revert "Library Publishing MVP (#1898)"" (#1933)
17c51a8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamrecursion iamrecursion iamrecursion approved these changes

@4e6 4e6 Awaiting requested review from 4e6

@kustosz kustosz Awaiting requested review from kustosz

Assignees

@radeusgd radeusgd

Labels
-tooling Category: tooling p-high Should be completed in the next sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@radeusgd @iamrecursion