Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table to JSON serialization #1937

Merged
merged 4 commits into from
Aug 10, 2021
Merged

Table to JSON serialization #1937

merged 4 commits into from
Aug 10, 2021

Conversation

kustosz
Copy link
Contributor

@kustosz kustosz commented Aug 10, 2021

Pull Request Description

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@kustosz kustosz added Type: Enhancement --breaking Important: a change that will break a public API or user-facing behaviour labels Aug 10, 2021
@kustosz kustosz self-assigned this Aug 10, 2021
iamrecursion
iamrecursion approved these changes Aug 10, 2021
View reviewed changes
Copy link
Contributor

@iamrecursion iamrecursion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff. Just one wording niggle.

RELEASES.md Outdated Show resolved Hide resolved
@kustosz @iamrecursion
Update RELEASES.md
2f7c1da 
Co-authored-by: Ara Adkins <iamrecursion@users.noreply.github.com>
@kustosz kustosz merged commit ca8252c into main Aug 10, 2021
@kustosz kustosz deleted the wip/mk/json_table branch August 10, 2021 13:35
iamrecursion pushed a commit that referenced this pull request Aug 13, 2021
@kustosz @iamrecursion
Table to JSON serialization (#1937)
c86092e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamrecursion iamrecursion iamrecursion approved these changes

@4e6 4e6 Awaiting requested review from 4e6

@radeusgd radeusgd Awaiting requested review from radeusgd

Assignees

@kustosz kustosz

Labels
--breaking Important: a change that will break a public API or user-facing behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kustosz @iamrecursion