Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix visualization interrupts #1939

Merged
merged 5 commits into from
Aug 11, 2021
Merged

Fix visualization interrupts #1939

merged 5 commits into from
Aug 11, 2021

Conversation

kustosz
Copy link
Contributor

@kustosz kustosz commented Aug 11, 2021

Pull Request Description

  1. Fixes the way visualizations are called, making sure they are always registered with the thread manager.
  2. Fixes an issue where an interrupted visualization would not recompute later.

Fixes #1895

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@kustosz kustosz self-assigned this Aug 11, 2021
iamrecursion
iamrecursion approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@iamrecursion iamrecursion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@kustosz kustosz merged commit a69d978 into main Aug 11, 2021
@kustosz kustosz deleted the wip/mk/vis_interrupt branch August 11, 2021 11:06
iamrecursion pushed a commit that referenced this pull request Aug 13, 2021
@kustosz @iamrecursion
Fix visualization interrupts (#1939)
a9702f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4e6 4e6 4e6 approved these changes

@iamrecursion iamrecursion iamrecursion approved these changes

@radeusgd radeusgd Awaiting requested review from radeusgd

Assignees

@kustosz kustosz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

executionContext/visualisationEvaluationFailed appears randomly
3 participants
@kustosz @4e6 @iamrecursion