Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slow file reading #1949

Merged
merged 7 commits into from
Aug 13, 2021
Merged

Fix slow file reading #1949

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
12d83f5
fix
kustosz Aug 12, 2021
8d43a20
add changelog
kustosz Aug 12, 2021
d4f76e8
Merge branch 'main' into wip/mk/fix_slow_file
kustosz Aug 12, 2021
fd46e73
Merge branch 'main' into wip/mk/fix_slow_file
kustosz Aug 12, 2021
d61ccdf
Merge branch 'main' into wip/mk/fix_slow_file
kustosz Aug 13, 2021
c730916
Merge branch 'main' into wip/mk/fix_slow_file
kustosz Aug 13, 2021
c0308a6
fix changelog
kustosz Aug 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions RELEASES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
([#1937](https://github.com/enso-org/enso/pull/1937)).
- Added support for parsing CSV files with too many headers declared
([#1942](https://github.com/enso-org/enso/pull/1942)).
- Fixed a bug where reading binary and text files would be 100 times slower than
expected ([#1949](https://github.com/enso-org/enso/pull/1949)).
- Added a single entry point method for all table serialization modes
([#1946](https://github.com/enso-org/enso/pull/1946)).

Expand Down
4 changes: 2 additions & 2 deletions distribution/lib/Standard/Base/0.1.0/src/System/File.enso
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,7 +570,7 @@ type Input_Stream
read_all_bytes : Vector.Vector ! File_Error
read_all_bytes = Managed_Resource.with this.stream_resource java_stream->
here.handle_java_exceptions this.file <|
Vector.from_array java_stream.readAllBytes
Vector.Vector java_stream.readAllBytes

## ADVANCED

Expand Down Expand Up @@ -601,7 +601,7 @@ type Input_Stream
read_n_bytes n = Managed_Resource.with this.stream_resource java_stream->
here.handle_java_exceptions this.file <|
bytes = java_stream.readNBytes n
Vector.from_array bytes
Vector.Vector bytes

## ADVANCED

Expand Down