Register Views before creating them

[akavel]

Pull Request Description

Make sure components implementing the View trait are registered in view::Registry, so that their keyboard shortcuts can be displayed to the user in a help window immediately after the IDE is started.

Fixes #3093.

Important Notes

• components that did not emit warnings, but still implement the View trait, were also tracked and case-by-case decisions taken to make sure appropriate registering behavior is performed; in particular:
  • FloatLabel was modified to not implement View, as it's a private widget and not expected to need keyboard shortcuts
  • NumberPicker & NumberRangePicker were registered
  • Scrollbar was skipped for now as it's understood to not be complete & ready to use yet
  • TopButtons was registered (tested with ?is_in_cloud=true)
  • CloseButton was modified to not implement View (the widget seems also internal: its creation was actually not even via new_view; it was used in 2 separate specializations & places as "close button" and "fullscreen button"; it had no keyboard shortcuts; a decision as of now was made to de-View it, with a possibility to reconsider in future if the understanding of its situation changes/develops)

Checklist

Please include the following checklist in your PR:

• The documentation has been updated if necessary.
• All code conforms to the Scala, Java, and Rust style guides.
• All documentation and configuration conforms to the markdown and YAML style guides.
• All code has been tested where possible.

[farmaazon]

I'm not sure if this comment is right. First, I'm not sure what is a different specialization - Rust does not have specializations in c++ style. And the entry does not affect the way the shortcut are handled, so it fact each ListView should have the same label.

[akavel]

Indeed. Now that I think of it, if guidelines should be provided anywhere, I'd rather expect to see them in View trait's docs, forming a part of the trait's contract description. With that said, I'm more than happy to remove it from here. It's not however clear to me what are the rules around the various methods of View, so I don't currently feel confident to be adding docs to View.

Do you think it'd be ok for me to just remove this comment here, or would you suggest I try adding comments in View, or somewhere else?

[farmaazon]

I'm ok with just removing it.