Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Truffle and Graal to Version 21.3.0 (#180303532) #3258

Merged
merged 11 commits into from
Feb 11, 2022

Conversation

ekmett
Copy link
Contributor

@ekmett ekmett commented Feb 8, 2022

Pull Request Description

This upgrades our graal version to 21.3.0.

To make this efficient there's some work that Jaroslav did to interrupt at TruffleSafepoints. This should fix the performance regressions we saw moving to the newer Truffle.

Important Notes

We have some fairly delicate (read broken) steps in our build-process. This patch doesn't currently fix those!

You'll need to install Graal 21.3.0, most likely with sdkman.

Then you should delete the cached truffle internals jar that we download:

$ rm ./engine/runtime/build-cache/truffle-api.jar 

Without doing that step you'll still be building against the 21.1.0 jar.

Finally, if you are working in a directory that has already built Enso, then you'll need to clean the intermediate results from the interpreter-dsl

$ sbt interpteter-dsl/clean

as the runtime doesn't seem to have a proper dependency on that.

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

Interrupting at TruffleSafepoint
@ekmett ekmett force-pushed the compiler/wip/eak/update-graal-vm branch from 304ec58 to 5d50ace Compare February 8, 2022 15:29
@ekmett ekmett requested a review from wdanilo as a code owner February 8, 2022 15:36
@ekmett ekmett self-assigned this Feb 8, 2022
@mwu-tow
Copy link
Contributor

mwu-tow commented Feb 8, 2022

The new Engine CI failures are my fault, I will fix them tomorrow.

@ekmett
Copy link
Contributor Author

ekmett commented Feb 8, 2022

@mwu-tow Roger. If I've missed some other location where 21.1.0 is mentioned, let me know. I've been going through the repo with as fine a toothed comb as I can.

@ekmett
Copy link
Contributor Author

ekmett commented Feb 9, 2022

At least one of the build failures is that native-image is looking around for x86_64-linux-musl-gcc, a rather specific compiler name on linux.

@mwu-tow
Copy link
Contributor

mwu-tow commented Feb 9, 2022

@ekmett Sorry, I need one more day for this.

I thought it would be enough to use newer Graal version. But yes, after this is done there's this x86_64-linux-musl-gcc thingy. I'll add build script support for setting this up.

Roger. If I've missed some other location where 21.1.0 is mentioned, let me know. I've been going through the repo with as fine a toothed comb as I can.

The new build script had this hardcoded, but it is currently on a separate repo (ci-build). I'm adding deducing Graal version from build.sbt definition to avoid duplicating of this hardcoded value.

@ekmett
Copy link
Contributor Author

ekmett commented Feb 9, 2022

That would explain why I couldn't find it. =)

@4e6 4e6 merged commit 0c25ee7 into develop Feb 11, 2022
@4e6 4e6 deleted the compiler/wip/eak/update-graal-vm branch February 11, 2022 16:05
@4e6 4e6 mentioned this pull request Feb 14, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants