-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Truffle and Graal to Version 21.3.0 (#180303532) #3258
Conversation
Interrupting at TruffleSafepoint
304ec58
to
5d50ace
Compare
The new Engine CI failures are my fault, I will fix them tomorrow. |
@mwu-tow Roger. If I've missed some other location where 21.1.0 is mentioned, let me know. I've been going through the repo with as fine a toothed comb as I can. |
At least one of the build failures is that |
@ekmett Sorry, I need one more day for this. I thought it would be enough to use newer Graal version. But yes, after this is done there's this
The new build script had this hardcoded, but it is currently on a separate repo (ci-build). I'm adding deducing Graal version from build.sbt definition to avoid duplicating of this hardcoded value. |
That would explain why I couldn't find it. =) |
Pull Request Description
This upgrades our graal version to 21.3.0.
To make this efficient there's some work that Jaroslav did to interrupt at TruffleSafepoints. This should fix the performance regressions we saw moving to the newer Truffle.
Important Notes
We have some fairly delicate (read broken) steps in our build-process. This patch doesn't currently fix those!
You'll need to install Graal 21.3.0, most likely with
sdkman
.Then you should delete the cached truffle internals jar that we download:
Without doing that step you'll still be building against the 21.1.0 jar.
Finally, if you are working in a directory that has already built Enso, then you'll need to clean the intermediate results from the interpreter-dsl
as the runtime doesn't seem to have a proper dependency on that.
Checklist
Please include the following checklist in your PR: