Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Text.at and Text.is_digit functions #3269

Merged
merged 7 commits into from
Feb 14, 2022

Conversation

jdunkerley
Copy link
Member

@jdunkerley jdunkerley commented Feb 11, 2022

Pull Request Description

Adding Text.at index based access to extended grapheme clusters.
Adding Text.is_digit method.

Important Notes

When using a negative index, the function has to realise the full grapheme cluster set.

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

Copy link
Member

@wdanilo wdanilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As always, I love the detailed tests for these functions!

@jdunkerley jdunkerley merged commit 585afd8 into develop Feb 14, 2022
@jdunkerley jdunkerley deleted the wip/jd/test-is_digit-181176532 branch February 14, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants