Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Integer.Parse #3283

Merged
merged 8 commits into from
Feb 17, 2022
Merged

Adding Integer.Parse #3283

merged 8 commits into from
Feb 17, 2022

Conversation

jdunkerley
Copy link
Member

@jdunkerley jdunkerley commented Feb 17, 2022

Pull Request Description

Implementing Integer.Parse - based on Long.parseLong

Important Notes

  • worth considering moving to builtins space but will do this as a later task
  • speed benefits over Decimal.parse .floor - 138ms vs 86ms for 1mm parses

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH ./run dist and ./run watch.

Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think as we are trying to have quite comprehensive tests, it may be worth adding a few more tests - mostly so that we can catch any regressions in the future.

@jdunkerley jdunkerley enabled auto-merge (squash) February 17, 2022 14:12
@jdunkerley jdunkerley merged commit 7afc8c4 into develop Feb 17, 2022
@jdunkerley jdunkerley deleted the wip/jd/integer-parse-181176522 branch February 17, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants