Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data analysts should be able to use Text.starts_with and Text.ends_with #3292

Merged
merged 8 commits into from
Feb 23, 2022
Merged

Data analysts should be able to use Text.starts_with and Text.ends_with #3292

merged 8 commits into from
Feb 23, 2022

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Feb 18, 2022 •
edited
Loading

Pull Request Description

Implements https://www.pivotaltracker.com/story/show/181265900

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH ./run dist and ./run watch.

@radeusgd radeusgd self-assigned this Feb 18, 2022
@radeusgd radeusgd force-pushed the wip/radeusgd/text-contains-181265795 branch 3 times, most recently from fcdee07 to 264fe31 Compare February 22, 2022 13:28
Base automatically changed from wip/radeusgd/text-contains-181265795 to develop February 22, 2022 15:41
@radeusgd radeusgd force-pushed the wip/radeusgd/text-starts-ends-with-181265900 branch 2 times, most recently from d093d62 to 52c108c Compare February 23, 2022 12:31
@radeusgd radeusgd marked this pull request as ready for review February 23, 2022 13:06
@radeusgd radeusgd force-pushed the wip/radeusgd/text-starts-ends-with-181265900 branch from 9284a15 to ab66710 Compare February 23, 2022 13:10
@radeusgd radeusgd force-pushed the wip/radeusgd/text-starts-ends-with-181265900 branch from ab66710 to c870875 Compare February 23, 2022 13:10
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Feb 23, 2022
@mergify mergify bot merged commit 2ae636f into develop Feb 23, 2022
@mergify mergify bot deleted the wip/radeusgd/text-starts-ends-with-181265900 branch February 23, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdunkerley jdunkerley jdunkerley approved these changes

@4e6 4e6 Awaiting requested review from 4e6

Assignees

@radeusgd radeusgd

Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@radeusgd @jdunkerley