Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text.pad and Text.trim #3309

Merged
merged 9 commits into from
Mar 2, 2022
Merged

Text.pad and Text.trim #3309

merged 9 commits into from
Mar 2, 2022

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Mar 1, 2022 •
edited
Loading

Pull Request Description

Implements https://www.pivotaltracker.com/story/show/181265516

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH ./run dist and ./run watch.

@radeusgd radeusgd force-pushed the wip/radeusgd/text-pad-trim-181265516 branch from f6ba121 to 49f50b1 Compare March 2, 2022 13:57
@radeusgd radeusgd marked this pull request as ready for review March 2, 2022 13:58
@radeusgd radeusgd self-assigned this Mar 2, 2022
jdunkerley
jdunkerley requested changes Mar 2, 2022
View reviewed changes
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of very minor ones but otherwise LGTM

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Extensions.enso Show resolved Hide resolved
test/Tests/src/Data/Text_Spec.enso Show resolved Hide resolved
@radeusgd radeusgd requested a review from jdunkerley March 2, 2022 15:42
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Mar 2, 2022
@mergify mergify bot merged commit 40c851b into develop Mar 2, 2022
@mergify mergify bot deleted the wip/radeusgd/text-pad-trim-181265516 branch March 2, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdunkerley jdunkerley jdunkerley approved these changes

@4e6 4e6 Awaiting requested review from 4e6

Assignees

@radeusgd radeusgd

Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@radeusgd @jdunkerley