Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource management in ModuleCache #3367

Merged
merged 3 commits into from
Mar 29, 2022
Merged

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented Mar 29, 2022

Pull Request Description

PR fixes an issue when compiler crashes while trying to load an incompatible IR cache.

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH ./run dist and ./run watch.

@4e6 4e6 added Type: Bug p-high Should be completed in the next sprint labels Mar 29, 2022
@4e6 4e6 self-assigned this Mar 29, 2022
@4e6 4e6 requested a review from radeusgd March 29, 2022 08:31
Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Would it be possible to add a test for this error scenario or is it too cumbersome to set this up making it not quite worth it?

@4e6
Copy link
Contributor Author

4e6 commented Mar 29, 2022

Would it be possible to add a test for this error scenario or is it too cumbersome to set this up making it not quite worth it?

For the test I'd need to store some old version of IR, and then try to load it. It's not trivial to do

@4e6 4e6 added the CI: Ready to merge This PR is eligible for automatic merge label Mar 29, 2022
@mergify mergify bot merged commit 435d7bb into develop Mar 29, 2022
@mergify mergify bot deleted the wip/db/fix-compiler-cache branch March 29, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge p-high Should be completed in the next sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants