Restructuring for File.read

[jdunkerley]

Pull Request Description

• Added Encoding type
• Added Text.bytes, Text.from_bytes with Encoding support
• Renamed File.read to File.read_text
• Renamed File.write to File.write_text
• Added Encoding support to File.read_text and File.write_text
• Added warnings to invalid encodings

Checklist

Please include the following checklist in your PR:

• The documentation has been updated if necessary.
• All code conforms to the Scala, Java, and Rust style guides.
• All code has been tested:
  • Unit tests have been written where possible.
  • If GUI codebase was changed: Enso GUI was tested when built using BOTH ./run dist and ./run watch.

[hubertp]

DRY?

[jdunkerley]

felt the generic solution wasn't very clean:

  private static <T extends Buffer> T resize(T old, IntFunction<T> allocate, BiConsumer<T, T> put) {
    int n = old.capacity();
    int new_n = 2*n + 1;
    T o = allocate.apply(new_n);
    old.flip();
    put.accept(o, old);
    return o;
  }

as Buffer doesn't have put or allocate. But happy to switch to generic if you think better.

[radeusgd]

I would actually argue for having the two specializations.
Maybe it is premature optimization, but feels like having ByteBuffer or CharBuffer directly can allow the JVM to statically resolve the methods to be used whereas having the closures it may not realise this is possible, at least that quickly. And it may be important because encoding is quite a primitive operation, which can work with quite big amounts of data and so performance is valuable here.

But if @hubertp you think it shouldn't matter much (I don't have enough JVM experience to judge if the overhead of closures here is noticeable or not), then I agree that a generic solution is more elegant.

[jdunkerley]

don't think it will have any performance overhead as just method references being passed - does make it slightly cleaner to only have the method once.

The Buffer class is ancient so not thought about for this stuff!

[radeusgd]

Looks good, but some changes are needed.

[radeusgd]

Looks great now, as long as tests go through should be good to go :)