Frgaal integration in sbt #3421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-working since it chokes on generated classes from annotation processor.
For reasons unknown AutoService would fail to initialize and fail to generate required builtin method classes. Hidden error message is not particularly revealing on the reason for that: ``` [error] error: Bad service configuration file, or exception thrown while constructing Processor object: javax.annotation.processing.Processor: Provider com.google.auto.service.processor.AutoServiceProcessor could not be instantiated ``` The sample records is only to demonstrate that we can now use newer Java features.
|
@JaroslavTulach Runtime now compiles with a sample feature from latest Java. If you are OK with this I will apply this setting to all subprojects and make it non-WIP. |
JaroslavTulach
approved these changes
Apr 28, 2022
lib/scala/interpreter-dsl/src/main/java/org/enso/interpreter/dsl/MethodProcessor.java
Show resolved
Hide resolved
Bench requires jmh classes which are not available because we obviously had to limit `java.base` modules to get Frgaal to work nicely. For now, we default to good ol' javac for Benchmarks. Limiting Frgaal to runtime for now, if it plays nicely, we can expand it to other projects.
radeusgd
reviewed
Apr 28, 2022
radeusgd
reviewed
Apr 28, 2022
|
@JaroslavTulach do we want to switch to Java 17 GraalVM in the future? |
mergify bot
pushed a commit
that referenced
this pull request
Jul 19, 2022
Updating to Frgaal 19.0.0-RC1 to give us access to latest Java features including pattern matching on `record` classes. Builds upon #3421.
jdunkerley
pushed a commit
that referenced
this pull request
Jul 20, 2022
Updating to Frgaal 19.0.0-RC1 to give us access to latest Java features including pattern matching on `record` classes. Builds upon #3421.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Frgaal allows to use latest Java features without requiring users to upgrade their runtime.
There is however no ready plugin for sbt to integrate with it.
This change replaces the regular local java compiler in the sbt definition.
Related to #181988063
Important Notes
This change demonstrates that we can compile shiny 16+ Java features without upgrading the requirements for the end users.
This currently migrates only runtime to Frgaal. We can eventually move other projects to that compiler as well.
For reasons unknown AutoService would fail to initialize and fail to
generate required builtin method classes.
Hidden error message is not particularly revealing on the reason for
that:
Replaced AutoService with ServiceProvider which does seem to do exactly the same thing.
Checklist
Please include the following checklist in your PR:
./run distand./run watch.