Sum type info in suggestions DB #3422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I skipped review of runtime/* for two reasons:
- I don't understand that code base much.
- it is not really important how this is implemented
I am focusing on
- tests - they look great.
@SuggestionAPI - the proposed state differs from the current spec
It would make it easier for me to keep the implementation, keep the tests and drop the suggestions part and redo it just like #3407 shows. The other option is to update the design spec.
engine/runtime/src/test/scala/org/enso/compiler/test/context/SuggestionBuilderTest.scala
Outdated
Show resolved
Hide resolved
engine/runtime/src/test/scala/org/enso/compiler/test/context/SuggestionBuilderTest.scala
Outdated
Show resolved
Hide resolved
engine/polyglot-api/src/main/scala/org/enso/polyglot/Suggestion.scala
Outdated
Show resolved
Hide resolved
JaroslavTulach
approved these changes
Apr 28, 2022
| .Argument("this", "Unnamed.Test.MyType", false, false, None) | ||
| .Argument( | ||
| "this", | ||
| "Unnamed.Test.MyType", |
There was a problem hiding this comment.
What is the reason for this change? Some automatic refactoring? Otherwise the new construct looks semantically the same as the old one to me.
There was a problem hiding this comment.
Yeah, style hint from IntelliJ (one that I agree with – use named args for booleans)
engine/runtime/src/test/scala/org/enso/compiler/test/context/SuggestionBuilderTest.scala
Show resolved
Hide resolved
engine/runtime/src/test/scala/org/enso/compiler/test/context/SuggestionBuilderTest.scala
Show resolved
Hide resolved
4 tasks
4e6
approved these changes
May 4, 2022
CHANGELOG.md
Outdated
| @@ -198,6 +199,8 @@ | |||
| [3412]: https://github.com/enso-org/enso/pull/3412 | |||
| [3414]: https://github.com/enso-org/enso/pull/3414 | |||
| [3417]: https://github.com/enso-org/enso/pull/3417 | |||
| [3417]: https://github.com/enso-org/enso/pull/3417 | |||
| @@ -30,6 +30,10 @@ sealed trait Tree[+A] { | |||
| final def map[B](f: A => B): Tree[B] = | |||
| Tree.map(this)(f) | |||
|
|
|||
| @JsonIgnore | |||
| final def collectFirst[B](f: PartialFunction[A, B]): Option[B] = | |||
| @@ -639,6 +652,9 @@ object SuggestionBuilder { | |||
| sealed private trait TypeArg | |||
| private object TypeArg { | |||
|
|
|||
| case class Sum(name: QualifiedName, variants: Seq[QualifiedName]) | |||
| throw new CompilerError( | ||
| "Bindings cannot be obtained from an abstract module reference." | ||
| ) | ||
| def resolveTypeName( |
| @@ -721,6 +731,8 @@ object BindingsMap { | |||
| */ | |||
| case class Cons(name: String, arity: Int, allFieldsDefaulted: Boolean) | |||
|
|
|||
| case class Type(name: String, members: Seq[String]) | |||
| def toConcrete(moduleMap: ModuleMap): Option[ResolvedTypeName] | ||
| } | ||
|
|
||
| case class ResolvedType(override val module: ModuleReference, tp: Type) |
| /** A result of successful name resolution. | ||
| */ | ||
| sealed trait ResolvedName { | ||
| def module: ModuleReference | ||
| sealed trait ResolvedName extends ResolvedTypeName { |
There was a problem hiding this comment.
proably doc should be updated as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
A draft of simple changes to the compiler to expose sum type information. Doesn't break the stdlib & at the same time allows for dropdowns. This is still broken, for example it doesn't handle exporting/importing types, only ones defined in the same module as the signature. Still, seems like a step in the right direction – please provide feedback.
Important Notes
I've decided to make the variant info part of the type, not the argument – it is a property of the type logically.
Also, I've pushed it as far as I'm comfortable – i.e. to the
SuggestionHandler– I have no idea if this is enough to show in IDE? cc @4e6Checklist
Please include the following checklist in your PR:
./run distand./run watch.