Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Table from Text conversion #3478

Merged
merged 4 commits into from
May 26, 2022
Merged

Implement Table from Text conversion #3478

merged 4 commits into from
May 26, 2022

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented May 24, 2022 •
edited
Loading

Pull Request Description

Implements https://www.pivotaltracker.com/story/show/181824168

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the
    Scala,
    Java,
    and
    Rust
    style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH
      ./run.sh ide dist and ./run.sh ide watch.

@radeusgd radeusgd self-assigned this May 24, 2022
@radeusgd radeusgd force-pushed the wip/radeusgd/delimited-infer-headers-181986831 branch from 8ef75e0 to f1f142c Compare May 25, 2022 08:52
@radeusgd radeusgd force-pushed the wip/radeusgd/text-to-table-181824168 branch from 0f86613 to 9e8af56 Compare May 25, 2022 08:52
@radeusgd radeusgd force-pushed the wip/radeusgd/delimited-infer-headers-181986831 branch 2 times, most recently from 150571c to 5c40488 Compare May 25, 2022 09:41
@radeusgd radeusgd force-pushed the wip/radeusgd/text-to-table-181824168 branch 2 times, most recently from c984f67 to 5358dec Compare May 25, 2022 10:46
Base automatically changed from wip/radeusgd/delimited-infer-headers-181986831 to develop May 25, 2022 13:29
@radeusgd radeusgd force-pushed the wip/radeusgd/text-to-table-181824168 branch from 5358dec to d4c7ac8 Compare May 25, 2022 14:34
@radeusgd radeusgd requested a review from hubertp May 25, 2022 16:12
hubertp
hubertp approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@hubertp hubertp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c&p typo in method signature

distribution/lib/Standard/Table/0.0.0-dev/src/Internal/Delimited_Reader.enso Outdated Show resolved Hide resolved
@radeusgd radeusgd force-pushed the wip/radeusgd/text-to-table-181824168 branch from d4c7ac8 to dfa0c25 Compare May 26, 2022 09:56
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label May 26, 2022
@mergify mergify bot merged commit 8828d80 into develop May 26, 2022
@mergify mergify bot deleted the wip/radeusgd/text-to-table-181824168 branch May 26, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubertp hubertp hubertp approved these changes

@jdunkerley jdunkerley jdunkerley approved these changes

@4e6 4e6 Awaiting requested review from 4e6

@JaroslavTulach JaroslavTulach Awaiting requested review from JaroslavTulach

Assignees

@radeusgd radeusgd

Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@radeusgd @hubertp @jdunkerley