Support Autosave for open buffers #3637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubertp
force-pushed
the
wip/hubert/autosave-182721656
branch
from
9bc75e4
to
cba99e9
Compare
JaroslavTulach
approved these changes
Aug 10, 2022
| ### `text/autoSave` | ||
|
|
||
| This is a notification sent from the server to the clients to inform them of any | ||
| successful auto-save action. |
| timeoutCancellable: Cancellable | ||
| ): Receive = { | ||
| case IOTimeout => | ||
| replyTo ! SaveFailed(OperationTimeout) | ||
| replyTo.foreach(_ ! SaveFailed(OperationTimeout)) |
There was a problem hiding this comment.
replyTo be None and None.foreach is a check to do nothing, I see.
engine/language-server/src/main/scala/org/enso/languageserver/text/CollaborativeBuffer.scala
Show resolved
Hide resolved
engine/language-server/src/main/scala/org/enso/languageserver/boot/MainModule.scala
Outdated
Show resolved
Hide resolved
4e6
approved these changes
Aug 10, 2022
engine/language-server/src/main/scala/org/enso/languageserver/boot/MainModule.scala
Outdated
Show resolved
Hide resolved
engine/language-server/src/main/scala/org/enso/languageserver/text/CollaborativeBuffer.scala
Show resolved
Hide resolved
4e6
requested changes
Aug 10, 2022
There was a problem hiding this comment.
I just realized that there is a text/openBuffer command that creates an in-memory buffer. And we should not run the auto-save logic for buffers that were opened this way.
I think we can get away with an extra isInMemory state in the CollaborativeBuffer actor
This change adds the auto-save action that will be schedule after every edit request. If no edit happens after the auto-save delay, language server will automatically trigger file saving. This does not yet trigger propagate the information about the successful save to the sender of the last edit request.
Minor cleanup to avoid spurious messages.
hubertp
force-pushed
the
wip/hubert/autosave-182721656
branch
from
f797a8f
to
0f67a00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This change adds Autosave action for open buffers. The action is scheduled
after every edit request and is cancelled by every explicit save file request, if
necessary. Successful autosave also notifies any active clients of the buffer.
Related to https://www.pivotaltracker.com/story/show/182721656
Important Notes
WIP
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide distand./run ide watch.