Text rendering quality improvements. #3855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdanilo
requested review from
MichaelMauderer,
farmaazon,
mwu-tow and
kazcw
as code owners
mwu-tow
approved these changes
Nov 8, 2022
Comment on lines
+46
to
+47
| /// Also, you can interactively change the values by holding `ctrl + alt + o` or `ctrl + alt + e` | ||
| /// keys and using the `+` and `-` key to increment or decrement the value. |
There was a problem hiding this comment.
Known to not work on Windows.
| lazy_static! { | ||
| /// A global hinting map for fonts. Map a platform and a font nam pair to hinting information. | ||
| /// See [`Hinting`] to learn more. | ||
| pub static ref HINTING_MAP: HashMap<(Option<platform::Platform>, &'static str), Hinting> = |
There was a problem hiding this comment.
Perhaps https://doc.rust-lang.org/std/cell/struct.OnceCell.html could be used?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR:
mplus1pfont. You can use it now without issues. The default app font should be switched to this font in the future.Important
The glyph hinting could not work perfectly on all systems. It looks really good now on macOS (retinas), but can be suboptimal on Linux and Windows. We need to update MSDFgen library to fix some bugs and after that, the hinting on these systems will improve.
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide buildand./run ide watch.