Allow multiple exports of the same module #3897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when exporting the same module multiple times only the first statement would count and the rest would be discarded by the compiler. This change allows for multiple exports of the same module e.g., ``` export project.F1 from project.F1 export foo ``` Multiple exports may however lead to conflicts when combined with hiding names. Added logic in `ImportResolver` to detect such scenarios. This fixes https://www.pivotaltracker.com/n/projects/2539304/stories/183092447
hubertp
force-pushed
the
wip/hubert/multiple-exports-183092447
branch
from
77e965a
to
48a3ff6
Compare
JaroslavTulach
approved these changes
Nov 23, 2022
mergify bot
pushed a commit
that referenced
this pull request
Nov 24, 2022
The change that is now allowed due to #3897 This fixes the first problem mentioned in https://www.pivotaltracker.com/n/projects/2539304/stories/183833055
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Previously, when exporting the same module multiple times only the first statement would count and the rest would be discarded by the compiler.
This change allows for multiple exports of the same module e.g.,
Multiple exports may however lead to conflicts when combined with hiding names. Added logic in
ImportResolverto detect such scenarios.This fixes https://www.pivotaltracker.com/n/projects/2539304/stories/183092447
Important Notes
Added a bunch of scenarios to simulate pos and neg results.
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide buildand./run ide watch.