Report failed name resolutions in type signatures #4030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiler performed name resolution of literals in type signatures but would silently fail to report any problems. This meant that wrong names or forgotten imports would sneak in to stdlib. This change introduces 2 main changes: 1) failed name resolutions are appended in `TypeNames` pass 2) `GatherDiagnostics` pass also collects and reports failures from type signatures IR Updated stdlib so that it passes given the correct gatekeepers in place.
hubertp
requested review from
jdunkerley,
radeusgd,
4e6 and
JaroslavTulach
as code owners
JaroslavTulach
approved these changes
Jan 7, 2023
engine/runtime/src/test/scala/org/enso/compiler/test/semantic/TypeSignaturesTest.scala
Show resolved
Hide resolved
jdunkerley
approved these changes
Jan 9, 2023
distribution/lib/Standard/Table/0.0.0-dev/src/Excel/Excel_Reader.enso
Outdated
Show resolved
Hide resolved
Easy to make the mistake, as indicated by the changes.
…er.enso Co-authored-by: James Dunkerley <jdunkerley@users.noreply.github.com>
4e6
approved these changes
Jan 9, 2023
mergify
bot
deleted the
wip/hubert/report-errors-in-type-signatures-184173008
branch
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Compiler performed name resolution of literals in type signatures but would silently fail to report any problems.
This meant that wrong names or forgotten imports would sneak in to stdlib.
This change introduces 2 main changes:
TypeNamespassGatherDiagnosticspass also collects and reports failures from typesignatures IR
Updated stdlib so that it passes given the correct gatekeepers in place.
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide buildand./run ide watch.