Custom type conversion to double from large long #4099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubertp
requested review from
jdunkerley,
radeusgd,
4e6 and
JaroslavTulach
as code owners
JaroslavTulach
approved these changes
Jan 30, 2023
There was a problem hiding this comment.
If we are going the targetTypeMapping route, when we can fix assert problems of EnsoBigInteger discovered in #4074 by using target type mapping as well. There is a pivotal calling for resolving the BigInteger issue by upgrade to (not yet known) version of GraalVM. But targetTypeMapping would address those issues as well.
engine/polyglot-api/src/main/java/org/enso/polyglot/HostAccessFactory.java
Show resolved
Hide resolved
4e6
approved these changes
Jan 31, 2023
When a large long would be passed to a host call expecting a double, it would crash with a ``` Cannot convert '<some long>'(language: Java, type: java.lang.Long) to Java type 'double': Invalid or lossy primitive coercion ``` That is unlikely to be expected by users. It also came up in the Statistics examples during Sum. One could workaround it by forcing the conversion manually with `.to_decimal` but it is not a permanent solution. Instead this change adds a custom type mapping from Long to Double that will do it behind the scenes with no user interaction. The mapping kicks in only for really large longs.
hubertp
force-pushed
the
wip/hubert/lossy-coercion-184203977
branch
from
53b2caa
to
1c7198b
Compare
jdunkerley
approved these changes
Jan 31, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
When a large long would be passed to a host call expecting a double, it would crash with a
That is unlikely to be expected by users. It also came up in the Statistics examples during Sum. One could workaround it by forcing the conversion manually with
.to_decimalbut it is not a permanent solution.Instead this change adds a custom type mapping from Long to Double that will do it behind the scenes with no user interaction. The mapping kicks in only for really large longs.
Important Notes
Note that the safe range is hardcoded in Truffle and it is not accessible in enso packages. Therefore a simple c&p for that max safe long value was necessary.
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide buildand./run ide watch.