Recover from serialization failures #5591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e6
approved these changes
Feb 8, 2023
JaroslavTulach
approved these changes
Feb 9, 2023
| @@ -289,11 +289,20 @@ class SerializationManager(compiler: Compiler) { | |||
| case e: NotSerializableException => | |||
| logger.log( | |||
| Level.SEVERE, | |||
| s"Could not serialize module [$name]." | |||
| s"Could not serialize module [$name].", | |||
| e | |||
There was a problem hiding this comment.
Logging the exception is possible! Unrelated to this PR, but I believe we should use it everywhere - not swallow the exception.
An exception encountered during serialization prevents engine from continuation because it enters an infinite loop(!) in deserialization.
hubertp
force-pushed
the
wip/hubert/recover-from-serialization-crash-5037
branch
from
7f890ac
to
c3d4b33
Compare
mergify
bot
deleted the
wip/hubert/recover-from-serialization-crash-5037
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
An exception encountered during serialization prevents engine from continuing because it enters an infinite loop(!).
Important Notes
The aim of this PR is to make it possible for engine to recover from the serialization failures. Any failure would mean that we enter an infinite loop in deserialization which is in turn waiting for the serialization to finish (which will never happen).
In this particular case FQNs are referencing concrete modules. A separate PR will address that.
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide buildand./run ide watch.