Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked ide watch and ide start commands #5634

Merged
merged 19 commits into from
Mar 2, 2023
Merged

Conversation

mwu-tow
Copy link
Contributor

@mwu-tow mwu-tow commented Feb 12, 2023

Pull Request Description

This PR changes build script's ide watch and ide start commands, so they don't use electron-builder to package. Instead, they invoke electron directly, significantly reducing time overhead.

ide watch will now start Electron process, while continuously rebuilding gui and the client in the background. Changes can be puilled by reloading within the electron, or closing the electron and letting it start once again. To stop, the script should be interrupted with Ctrl+C.

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the
    Scala,
    Java,
    and
    Rust
    style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH
      ./run ide build and ./run ide watch.

@mwu-tow mwu-tow added CI: No changelog needed Do not require a changelog entry for this PR. -build-script Category: build script labels Feb 12, 2023
@mwu-tow mwu-tow self-assigned this Feb 12, 2023
@mwu-tow mwu-tow linked an issue Feb 12, 2023 that may be closed by this pull request
Copy link
Member

@wdanilo wdanilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so amazing!!!

@mwu-tow mwu-tow added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Mar 2, 2023
@mwu-tow mwu-tow merged commit ee981d2 into develop Mar 2, 2023
@mwu-tow mwu-tow deleted the wip/mwu/ide-watch branch March 2, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-build-script Category: build script CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starting IDE with electron without generating the package
3 participants