-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cached icons in Component Browser #5779
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farmaazon
requested review from
MichaelMauderer,
wdanilo and
mwu-tow
as code owners
February 28, 2023 15:09
kazcw
approved these changes
Feb 28, 2023
mwu-tow
approved these changes
Mar 1, 2023
QA reportIssuesThe icons of the component browser look visibly worse than before. Note the blurred "A" and "5" in Icons demo scene: Before: After: Note the two icons on the right and how the plus shape in the center looks different even when the dimensions are the same. These icons are not pixel-aligned, though.Other issuesReported #5786, this is probably not caused by this PR. |
@vitvakatu Fixes apply, please check them out. |
MichaelMauderer
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #5189
The component browser uses cached icons, both on the cached list and the navigator panel. It reduced the number of draw calls by 18.
Important Notes
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide build
and./run ide watch
.