Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Table.parse_text_to_table to convert Text to a Table. #6294

Merged
merged 25 commits into from
Apr 21, 2023
Merged

Add Table.parse_text_to_table to convert Text to a Table. #6294

merged 25 commits into from
Apr 21, 2023

Conversation

GregoryTravis
Copy link
Contributor

Pull Request Description

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@GregoryTravis GregoryTravis marked this pull request as ready for review April 17, 2023 13:33
jdunkerley
jdunkerley requested changes Apr 19, 2023
View reviewed changes
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, looks good.

Just an edge case to look at and suggest doing the parse as a post process (I know less memory efficient).

distribution/lib/Standard/Table/0.0.0-dev/src/Internal/Parse_To_Table.enso Outdated Show resolved Hide resolved
distribution/lib/Standard/Table/0.0.0-dev/src/Internal/Parse_To_Table.enso Outdated Show resolved Hide resolved
distribution/lib/Standard/Table/0.0.0-dev/src/Internal/Parse_To_Table.enso Outdated Show resolved Hide resolved
radeusgd
radeusgd approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me.

Just some minor suggestions.

@GregoryTravis GregoryTravis added the CI: Ready to merge This PR is eligible for automatic merge label Apr 21, 2023
@GregoryTravis GregoryTravis added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Apr 21, 2023
@radeusgd radeusgd mentioned this pull request Apr 21, 2023
Merged
5 tasks
@mergify mergify bot merged commit 22f820f into develop Apr 21, 2023
24 checks passed
@mergify mergify bot deleted the wip/gmt/5126-ptt branch April 21, 2023 17:43
@jdunkerley jdunkerley linked an issue Apr 24, 2023 that may be closed by this pull request
Add Text.parse_to_table to convert Text to a Table. #5126
Closed
Procrat added a commit that referenced this pull request Apr 25, 2023
@Procrat
Merge branch 'develop' into wip/procrat/rename-project-with-space-5065
04b228f 
* develop:
  Turn null into UnexpectedExpression when Union type is incomplete (#6415)
  Ensure that IO.println does not fail if `to_text` returned a non-Text value. (#6223)
  Improve inlining of `<|` on (GraalVM EE) (#6384)
  Feat: update templates styles and feature (#6071)
  5127 Add Table.parse_to_columns to parse a single column to a set of columns. (#6383)
  URL handling (#6243)
  Exclude comparison operators from modifier logic (#6370)
  Better cleanup of project management test suite (#6392)
  Fix all eslint errors (#6267)
  Infer SQLite types locally (#6381)
  Vector Editor with List Editor and adding elements. (#6363)
  Add typechecks to Aggregate and Cross Tab (#6380)
  Forbid edits in read-only mode (#6342)
  Add Table.parse_text_to_table to convert Text to a Table. (#6294)
  Adding typechecks to Column Operations (#6298)
  Rollback cloud options groups (#6331)
  Project folder not renamed after project name change (#6369)
  Add `replace`, `trim` to Column. Better number parsing. (#6253)
  Read-only mode for controllers (#6259)
  Prevent default for all events, fixing multiple IDE bugs (#6364)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radeusgd radeusgd radeusgd approved these changes

@jdunkerley jdunkerley jdunkerley approved these changes

Assignees
No one assigned
Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Text.parse_to_table to convert Text to a Table.
3 participants
@GregoryTravis @radeusgd @jdunkerley