Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle some edge cases in rounding (inexact representations and overflows) #6922

Merged
merged 58 commits into from Jun 5, 2023
Merged

Handle some edge cases in rounding (inexact representations and overflows) #6922

merged 58 commits into from Jun 5, 2023

Conversation

GregoryTravis
Copy link
Contributor

@GregoryTravis GregoryTravis commented Jun 1, 2023 •
edited

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@GregoryTravis
move each_propagate into Range
8c34ebb
@GregoryTravis
Column_Ops
3d8b55c
@GregoryTravis
round
2aa2302
@GregoryTravis
truncate ceil floor
5f0d00f
@GregoryTravis
unused
b8e5282
@GregoryTravis
all but date
97ab8ec
@GregoryTravis
examples
07527b6
@GregoryTravis
cleanup
b0ed569
@GregoryTravis
cleanup
c3818dc
@GregoryTravis
date_time truncate
35d83a1
@GregoryTravis
cleanup
430090f
@GregoryTravis
Merge branch 'develop' into wip/gmt/6805-col-round
f97554d
@GregoryTravis
fix format tests
2db1924
@GregoryTravis
check column types
8a62af2
@GregoryTravis
each_p no
759de4d
@GregoryTravis
noop
d616cea
@GregoryTravis
changelog, test fix
b85f558
@GregoryTravis
java fmt
82ed443
@GregoryTravis
review, throw
0eeb10e
@GregoryTravis
move adapter
e9be9d5
@GregoryTravis
Merge branch 'develop' into wip/gmt/6805-col-round
91babe2
@GregoryTravis
limit round input for float too
01f0f65
@GregoryTravis
Merge branch 'develop' into wip/gmt/6805-col-round
d6aa9ef
@GregoryTravis
unimplemented stubs
4a4e886
@GregoryTravis
Merge branch 'develop' into wip/gmt/6805-col-round
25cbea1
@GregoryTravis
generalize error
ac93d31
@GregoryTravis
Merge branch 'develop' into wip/gmt/6805-col-round
45c1754
@GregoryTravis
remove big num test
ea1fd0b
@GregoryTravis
Merge branch 'develop' into wip/gmt/6805-col-round
a48cf30
@GregoryTravis
regs but not bankers
0348cd6
Base automatically changed from wip/gmt/6805-col-round to develop June 1, 2023 20:06
@GregoryTravis GregoryTravis marked this pull request as ready for review June 2, 2023 16:15
jdunkerley
jdunkerley reviewed Jun 2, 2023
View reviewed changes
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few little comments.

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Numbers.enso Outdated Show resolved Hide resolved
distribution/lib/Standard/Base/0.0.0-dev/src/Data/Numbers.enso Outdated Show resolved Hide resolved
distribution/lib/Standard/Base/0.0.0-dev/src/Data/Numbers.enso Outdated Show resolved Hide resolved
distribution/lib/Standard/Base/0.0.0-dev/src/Data/Numbers.enso Show resolved Hide resolved
test/Tests/src/Data/Numbers_Spec.enso Show resolved Hide resolved
jdunkerley
jdunkerley approved these changes Jun 2, 2023
View reviewed changes
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few little comments.

jdunkerley
jdunkerley approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@GregoryTravis GregoryTravis added the CI: Ready to merge This PR is eligible for automatic merge label Jun 5, 2023
@mergify mergify bot merged commit 3ffbe9c into develop Jun 5, 2023
24 checks passed
@mergify mergify bot deleted the wip/gmt/6811-edge-cases branch June 5, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdunkerley jdunkerley jdunkerley approved these changes

@radeusgd radeusgd Awaiting requested review from radeusgd radeusgd is a code owner

Assignees
No one assigned
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GregoryTravis @radeusgd @jdunkerley