Add round, ceil, floor, truncate to the In-Database Column type #6988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregoryTravis
changed the title
|
This implementation of round is a generic, "by hand" version using column arithmetic. This approach will only be used in a few cases; most of the time we can use the built-in ROUND() function in both backends. |
radeusgd
approved these changes
Jun 27, 2023
GregoryTravis
added
the
CI: Ready to merge
jdunkerley
approved these changes
Jun 27, 2023
4e6
approved these changes
Jun 27, 2023
GregoryTravis
removed
the
CI: Ready to merge
radeusgd
reviewed
Jun 29, 2023
| if (!special) { | ||
| out[i] = doOperation(item); | ||
| } else { | ||
| String msg = "Value is " + item; |
There was a problem hiding this comment.
This error message needs to be more user friendly.
Suggested change
| String msg = "Value is " + item; | |
| String msg = "The operation " + name + " does not allow " + item + " as input, returning Nothing."; |
or sth like that
radeusgd
reviewed
Jun 29, 2023
|
|
||
| do_round -1.22222222225 10 . should_equal -1.2222222223 | ||
| do_round -1.222222222225 11 . should_equal -1.22222222223 | ||
| do_round -1.2222222222225 12 . should_equal -1.222222222223 | ||
| do_round -1.22222222222225 13 . should_equal -1.2222222222223 | ||
| do_round -1.222222222222225 14 . should_equal -1.22222222222223 | ||
| do_round -1.2222222222222225 15 . should_equal -1.222222222222223 |
There was a problem hiding this comment.
Because SQLite fails this test. I could add this one line to the backend-specific test, with different values.
There was a problem hiding this comment.
Why does it fail it? Should we be concerned? (if not a big deal, I'm ok with removing it)
There was a problem hiding this comment.
Moved to backend-specific tests.
radeusgd
approved these changes
Jun 29, 2023
radeusgd
approved these changes
Jun 29, 2023
radeusgd
reviewed
Jun 29, 2023
| @@ -123,7 +123,7 @@ sqlite_specific_spec prefix connection setup = | |||
| expected_code = code_template.replace "{Tinfo}" tinfo | |||
| t.distinct ["strs"] . to_sql . prepare . should_equal [expected_code, []] | |||
|
|
|||
| Test.group "[PostgreSQL] math functions" <| | |||
| Test.group "[PostgreSQL] math functionsasdfasdf" <| | |||
There was a problem hiding this comment.
Suggested change
| Test.group "[PostgreSQL] math functionsasdfasdf" <| | |
| Test.group "[PostgreSQL] math functions" <| |
please remove these random letters though :)
GregoryTravis
added
the
CI: Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.