Implement remaining Update_Actions for update_database_table.
#7035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeusgd
force-pushed
the
wip/radeusgd/update-database-table-contd
branch
from
9c2a4e4
to
e130f02
Compare
GregoryTravis
approved these changes
Jun 14, 2023
jdunkerley
approved these changes
Jun 15, 2023
| They key columns must be present under the same name in both tables. | ||
|
|
||
| This will usually be a query of the form | ||
| `DELETE FROM target WHERE (key_columns...) NOT IN (SELECT key_columns... FROM source)`. |
There was a problem hiding this comment.
I wonder if a DELETE/JOIN would work better.
Add a constant marker to the source, and then something like:
DELETE target
FROM target
LEFT JOIN source ON ...
WHERE source.marker is NULLThere was a problem hiding this comment.
This kind of syntax seems to not be supported in neither of the DBs we currently have.
There was a problem hiding this comment.
In SQLite the DELETE syntax only allows for a WHERE clause, no joins are available.
In Postgres, I guess we may try to play with MERGE but that is for a later ticket, I think - so to be revisited in #7036
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #6498
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.