Improving widgets and other minor tweaks. #7052

jdunkerley · 2023-06-16T17:08:53Z

Pull Request Description

Removed module argument from enso_project (new Project_Description.new API).
Removed the custom option from date and time parse/format dropdowns.
The format dropdown uses the value to create the dropdown. (Screenshot below)
Removed StorageType coalescing rules and replaced them with simpler logic in ObjectStorage.
Update signature for add_row_number and add aliases.

Screenshots

2023-06-19_11-44-58.mp4

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

The documentation has been updated, if necessary.
Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
All code follows the
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
All code has been tested:
- Unit tests have been written where possible.
- If GUI codebase was changed, the GUI was tested when built using ./run ide build.

…ed rules now in ObjectStorage.

Add ALIAS to `add_row_number`.

CHANGELOG.

GregoryTravis · 2023-06-19T16:38:06Z

distribution/lib/Standard/Base/0.0.0-dev/src/Main.enso

@@ -121,12 +120,16 @@ import project.Network.HTTP.HTTP_Version.HTTP_Version
 import project.Network.URI.URI
 import project.Random

+from project.Data.Json.Extensions import all


Was the original point of the Extensions files to speed up compilation/startup? Does this remove that benefit?

What do you mean? I don't understand your question. In these Extensions modules, we have extension methods, and we need to import and export all these methods. I have recently changed the form of these import and export statements as there was a clash of Extensions symbol.

GregoryTravis · 2023-06-19T16:41:06Z

distribution/lib/Standard/Base/0.0.0-dev/src/Meta/Enso_Project.enso

-    Project_Description.enso_project_builtin module
+enso_project : Project_Description ! Module_Not_In_Package_Error
+enso_project =
+    Project_Description.enso_project_builtin Nothing


Suggested change

Project_Description.enso_project_builtin Nothing

Project_Description.new Nothing

In case any further logic is added to new.

Has to be there as it moves one frame up to find where it was called from.

If we pass through new it then ends up saying where Standard.Base is.

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Time/Date.enso

radeusgd · 2023-06-19T17:24:44Z

distribution/lib/Standard/Table/0.0.0-dev/src/Data/Table.enso

@@ -1201,7 +1202,7 @@ type Table
           problem is reported.
    @group_by Widget_Helpers.make_column_name_vector_selector
    @order_by Widget_Helpers.make_order_by_selector
-    add_row_number : Text -> Integer -> Integer -> Vector (Text | Integer | Column_Selector) | Text | Integer | Column_Selector -> Vector (Text | Sort_Column) | Text | Sort_Column -> Problem_Behavior -> Table


Why are these removed? They are valid inputs IIRC and the widget should be based on the annotation anyway.

Is it due to a bug in dropdowns logic?

it should be but isn't yet - should be fixed one day but need to work around for now.

Do we have a ticket for it so that we can keep track of it?

IMO it may be worth to add a TODO note near the signature - as I assume once the bug is fixed, we should fixe the signature to allow this case.

No need for a todo as I don't see us needing to revert this change.

I'll raise the drop-down issues as a ticket.

radeusgd · 2023-06-19T17:26:33Z

std-bits/aws/src/main/java/org/enso/aws/ProfileReader.java

+    if (profiles == null) {
+      var provider = ProfileFileSupplier.defaultSupplier();
+      var profileFile = provider.get();
+      profiles = profileFile.profiles().keySet().toArray(new String[0]);
+    }


I'm going to be annoying, because it's exactly what I previously suggested.

But after even further though, shouldn't we reload the profiles on every call? Or have some way to reload them? What if someone adds a profile while Enso is running? Currently it seems that they would have to restart it for the changes to take effect, are we fine with that? I guess this may be OK, just asking to be sure.

I'll see if I can do anything in the next S3 work.

Generally a minor thing but if I can detect a change using AWS API will do.

radeusgd · 2023-06-19T17:28:03Z

std-bits/table/src/main/java/org/enso/table/data/column/storage/ObjectStorage.java

+        if (currentType instanceof AnyObjectType) {
+          break;
+        }


I like the early quit - for many storages it will mean that computing this will finish very quickly.

4e6 · 2023-06-19T17:42:09Z

...with-instruments/src/test/scala/org/enso/interpreter/test/instrument/RuntimeErrorsTest.scala

-      TestMessages.update(contextId, x1Id, ConstantsGen.NOTHING_BUILTIN),
-      TestMessages.update(contextId, mainRes1Id, ConstantsGen.NOTHING_BUILTIN),
+      TestMessages.update(contextId, x1Id, ConstantsGen.NOTHING),
+      TestMessages.update(contextId, mainRes1Id, ConstantsGen.NOTHING),


@jdunkerley this change is definitely not obvious.

Nothing is a builtin type, and they have special handling in the compiler. When the program is compiled

All the builtins are loaded into the scope, making the type of Nothing Standard.Builtins.Main.Nothing

When the compiler encounters the Nothing definition in the standard library
@Builtin_Type type Nothing
It shadows the builtin definition of Nothing with Standard.Base.Nothing.Nothing (the module where the new definition is)

Now returning to the test,

from Standard.Base.Errors.Common import all main = x = IO.println "MyError" x

The program imports Standard.Base.Errors.Common which in turn imports project.Meta, and this PR changes Meta.enso test/micro-distribution/lib/Standard/Base/0.0.0-dev/src/Meta.enso and adds

+from Standard.Base.Nothing import Nothing +

Now the compiler sees the definition of Nothing in the standard library and shadows the builtin definition. And that's why the return type of Nothing changes in the test.

jdunkerley added 8 commits June 19, 2023 08:49

Remove type coercion logic from StorageType. The reduced and simplifi…

8d8e897

…ed rules now in ObjectStorage.

Remove custom option from format dropdown.

50d4843

Cache AWS profiles.

ab49fee

Remove the module argument from enso_project.

f460f49

Fix failing tests.

d1497db

Java Format.

a788985

For format dropdowns use current value.

d482ffe

Adjust add_row_number signature to remove dropdown.

423deae

Add ALIAS to `add_row_number`.

jdunkerley force-pushed the wip/jd/s3-apis branch from 71af781 to 423deae Compare June 19, 2023 10:33

jdunkerley marked this pull request as ready for review June 19, 2023 16:32

jdunkerley requested review from radeusgd, GregoryTravis, 4e6, JaroslavTulach, hubertp and Akirathan as code owners June 19, 2023 16:32

jdunkerley changed the title ~~Improving widgets and S3 APIs~~ Improving widgets and other minor tweaks. Jun 19, 2023

Fix failing test.

498b061

CHANGELOG.

GregoryTravis approved these changes Jun 19, 2023

View reviewed changes

radeusgd reviewed Jun 19, 2023

View reviewed changes

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Time/Date.enso Show resolved Hide resolved

radeusgd reviewed Jun 19, 2023

View reviewed changes

radeusgd approved these changes Jun 19, 2023

View reviewed changes

4e6 approved these changes Jun 19, 2023

View reviewed changes

jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Jun 19, 2023

mergify bot merged commit 1859ccb into develop Jun 19, 2023
24 of 26 checks passed

mergify bot deleted the wip/jd/s3-apis branch June 19, 2023 19:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improving widgets and other minor tweaks. #7052

Improving widgets and other minor tweaks. #7052

jdunkerley commented Jun 16, 2023 •

edited

GregoryTravis Jun 19, 2023

Akirathan Jun 19, 2023

GregoryTravis Jun 19, 2023

jdunkerley Jun 19, 2023

radeusgd Jun 19, 2023

jdunkerley Jun 19, 2023

radeusgd Jun 19, 2023

jdunkerley Jun 19, 2023

radeusgd Jun 19, 2023

jdunkerley Jun 19, 2023

radeusgd Jun 19, 2023

4e6 Jun 19, 2023

	Project_Description.enso_project_builtin Nothing
	Project_Description.new Nothing

Improving widgets and other minor tweaks. #7052

Improving widgets and other minor tweaks. #7052

Conversation

jdunkerley commented Jun 16, 2023 • edited

Pull Request Description

Screenshots

Important Notes

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jdunkerley commented Jun 16, 2023 •

edited