Send info about function values #7168
Conversation
engine/polyglot-api/src/main/scala/org/enso/polyglot/runtime/Runtime.scala
Outdated
Show resolved
Hide resolved
| public static int[] collectNotAppliedArguments(Function function) { | ||
| FunctionSchema functionSchema = function.getSchema(); | ||
| Object[] preAppliedArguments = function.getPreAppliedArguments(); | ||
| boolean isStatic = preAppliedArguments[0] instanceof Type; |
There was a problem hiding this comment.
Is this reliable? We could have an argument which is a type but the function is not a static?
There was a problem hiding this comment.
Yes, to resolve the function the self argument has to be present. And at this point, the function is resolved.
If the function is not static, the self argument will be something like UnboxingAtom I believe.
...time-instrument-common/src/main/java/org/enso/interpreter/instrument/IdExecutionService.java
Outdated
Show resolved
Hide resolved
…untime.scala Co-authored-by: Hubert Plociniczak <hubert.plociniczak@gmail.com>
…reter/instrument/IdExecutionService.java Co-authored-by: Hubert Plociniczak <hubert.plociniczak@gmail.com>
mergify
bot
deleted the
wip/db/6957-send-info-about-function-values-to-the-ide
branch
| } | ||
|
|
||
| public static int[] collectNotAppliedArguments(Function function) { | ||
| FunctionSchema functionSchema = function.getSchema(); | ||
| Object[] preAppliedArguments = function.getPreAppliedArguments(); |
There was a problem hiding this comment.
What if the preAppliedArguments array has zero size? Will the next line not throw an ArrayIndexOutOfBoundsException?
| Option( | ||
| ctx.executionService.toDisplayString(warnings(0).getValue) | ||
| val warnings = | ||
| Option.when( |
There was a problem hiding this comment.
Replacing if with Option.when! I can only say: I am not fan of such aggressive functional rewrites.
| @@ -953,6 +963,109 @@ class RuntimeServerTest | |||
| ) | |||
| } | |||
|
|
|||
| it should "send method pointer updates of partially applied type method returning a method" in { | |||
There was a problem hiding this comment.
What will happen when the result is a function and remains a function yet its schema changes on subsequent evaluation of the result? Will we deliver an update to value/schema?
I am envisioning following test case:
f a b c = a + b + c
fn what = case what of
0 -> f
1 -> f 3
2 -> f 3 8
_ -> f 3 8 9what will happen if some code invoke fn 1 first and then the code get changed and invokes fn 2 - will the IDE be notified about the schema change?
Pull Request Description
close #6957
Extend
ExpressionUpdatemessage and send a function schema if the returned value is a function.Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.