Builtin methods can support array-like arguments #7235

Akirathan · 2023-07-07T11:44:45Z

Closes #7133.

In EnsoFile builtin type, we used to have builtin methods accepting array of some classes from java.io as parameters. That works only if such argument is converted with to_array. If Vector is passed, it fails.

This PR modifies the builtin method processor such that it forbids arrays of non-primitive and non-guest objects in builtin methods. And provides a proper implementation for the builtin methods in EnsoFile.

Pull Request Description

Builtin methods generator fails for a builtin method that has an array of host objects as parameter:

Important Notes

Add some useful javadoc generation to builtin methods processor.
Remove last Vector.to_array calls from File.enso.
Some quality of life improvements to the builtin method processor.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

The documentation has been updated, if necessary.
Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
All code follows the
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
All code has been tested:
- Unit tests have been written where possible.
- If GUI codebase was changed, the GUI was tested when built using ./run ide build.

…st project

Akirathan · 2023-07-07T11:46:46Z

build.sbt

+      Test / javacOptions ++= Seq(
+        "-s",
+        (Test / sourceManaged).value.getAbsolutePath
+      ),
+      Compile / logManager :=
+        sbt.internal.util.CustomLogManager.excludeMsg(
+          "Could not determine source for class ",
+          Level.Warn
+      ),


This fixes spurious errors in IDEA - the *MethodGen sources are now put into src_managed rather than on an unknown location inside target directory.

engine/runtime/src/main/java/org/enso/interpreter/runtime/data/Vector.java

JaroslavTulach

Ugly, but it fixes the problem.

JaroslavTulach · 2023-07-09T10:21:42Z

...nterpreter-dsl/src/main/java/org/enso/interpreter/dsl/builtins/MethodNodeClassGenerator.java

engine/runtime/src/main/java/org/enso/interpreter/runtime/data/Vector.java

JaroslavTulach · 2023-07-12T18:29:52Z

Caused by similar design flaw as

A Time_Of_Day represented by java.time.LocalTime fails TypesGen.expectEnsoTimeOfDay check #6912

…objects as parameter.

…ing" This reverts commit 4905630.

radeusgd · 2023-07-13T16:54:26Z

engine/runtime/src/main/java/org/enso/interpreter/runtime/data/EnsoFile.java

+    } catch (ClassCastException e) {
+      throw new PanicException(e, interop);
+    }


This should be a Type_Error also I think, not a ClassCastException wrapped in panic.

radeusgd · 2023-07-13T16:54:49Z

engine/runtime/src/main/java/org/enso/interpreter/runtime/data/EnsoFile.java

+          var err = ctx.getBuiltins().error().makeUnsupportedArgumentsError(
+              new Object[]{arr},
+              "Arguments to opts should be host objects from java.io package"
+          );


Again, can this be a Type_Error?

I think this is better as Unsupported_Argument_Types because it has a message field, as opposed to Type_Error that only has expected and actual types.

lib/scala/interpreter-dsl/src/main/java/org/enso/interpreter/dsl/builtins/MethodGenerator.java

JaroslavTulach · 2023-07-17T07:29:45Z

engine/runtime/src/main/java/org/enso/interpreter/runtime/data/EnsoFile.java

-    return this.truffleFile.newOutputStream(opts);
+  public OutputStream outputStream(Object opts,
+      EnsoContext ctx,
+      @CachedLibrary(limit = "5") InteropLibrary interop) throws IOException {


Combination of @TruffleBoundary and @CachedLibrary - the usual error...

Oh, my bad. I will fix that in one of my upcoming PRs - ea95a16

Akirathan added 4 commits July 7, 2023 13:08

Fix build warnings and code generation location of interpreter-dsl-te…

1ac6242

…st project

Add some useful javadoc generation to builtin methods processor

0fbc14a

Remove to_array method calls from File.enso

e7b1a6f

BuiltinMethodProcessor can handle array-like argument processing

4905630

Akirathan linked an issue Jul 7, 2023 that may be closed by this pull request

File's input_stream type signatures are inconsistent #7133

Closed

Akirathan self-assigned this Jul 7, 2023

Akirathan added the CI: No changelog needed Do not require a changelog entry for this PR. label Jul 7, 2023

Akirathan commented Jul 7, 2023

View reviewed changes

Akirathan marked this pull request as ready for review July 7, 2023 13:59

Akirathan requested review from jdunkerley, radeusgd, GregoryTravis, 4e6, JaroslavTulach and hubertp as code owners July 7, 2023 13:59

fmt

bc40ffa

radeusgd reviewed Jul 7, 2023

View reviewed changes

engine/runtime/src/main/java/org/enso/interpreter/runtime/data/Vector.java Outdated Show resolved Hide resolved

GregoryTravis approved these changes Jul 7, 2023

View reviewed changes

JaroslavTulach approved these changes Jul 9, 2023

View reviewed changes

enso-bot bot mentioned this pull request Jul 10, 2023

Dataflow error in a default of a type-ascribed argument results in a type error instead of being propagated #7137

Closed

hubertp approved these changes Jul 10, 2023

View reviewed changes

Akirathan added 6 commits July 13, 2023 10:41

Builtin method generator fails when builtin method has array of host …

f4e9593

…objects as parameter.

Revert "BuiltinMethodProcessor can handle array-like argument process…

6c3367d

…ing" This reverts commit 4905630.

Better diagnostics for builtin method processor

78b121b

EnsoFile converts interop array itself.

184aeaa

Update method signature of File.input_stream

57b2123

fmt

9a9ccf6

Akirathan force-pushed the wip/akirathan/7133-files-input_stream-type-signatures branch from 0d2004d to 9a9ccf6 Compare July 13, 2023 16:26

radeusgd reviewed Jul 13, 2023

View reviewed changes

lib/scala/interpreter-dsl/src/main/java/org/enso/interpreter/dsl/builtins/MethodGenerator.java Show resolved Hide resolved

Akirathan merged commit 7264d81 into develop Jul 17, 2023
26 of 27 checks passed

Akirathan deleted the wip/akirathan/7133-files-input_stream-type-signatures branch July 17, 2023 07:17

JaroslavTulach reviewed Jul 17, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Builtin methods can support array-like arguments #7235

Builtin methods can support array-like arguments #7235

Akirathan commented Jul 7, 2023 •

edited

Loading

Akirathan Jul 7, 2023

JaroslavTulach left a comment

JaroslavTulach Jul 9, 2023

JaroslavTulach commented Jul 12, 2023

radeusgd Jul 13, 2023

radeusgd Jul 13, 2023

Akirathan Jul 17, 2023

JaroslavTulach Jul 17, 2023

Akirathan Jul 17, 2023

Builtin methods can support array-like arguments #7235

Builtin methods can support array-like arguments #7235

Conversation

Akirathan commented Jul 7, 2023 • edited Loading

Pull Request Description

Important Notes

Checklist

Akirathan Jul 7, 2023

Choose a reason for hiding this comment

JaroslavTulach left a comment

Choose a reason for hiding this comment

JaroslavTulach Jul 9, 2023

Choose a reason for hiding this comment

JaroslavTulach commented Jul 12, 2023

radeusgd Jul 13, 2023

Choose a reason for hiding this comment

radeusgd Jul 13, 2023

Choose a reason for hiding this comment

Akirathan Jul 17, 2023

Choose a reason for hiding this comment

JaroslavTulach Jul 17, 2023

Choose a reason for hiding this comment

Akirathan Jul 17, 2023

Choose a reason for hiding this comment

Akirathan commented Jul 7, 2023 •

edited

Loading