-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add date_diff
, date_add
and date_part
to scalar Enso date-time values.
#7273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeusgd
added
the
CI: No changelog needed
Do not require a changelog entry for this PR.
label
Jul 12, 2023
GregoryTravis
approved these changes
Jul 12, 2023
radeusgd
force-pushed
the
wip/radeusgd/date-diff-add-for-scalars
branch
from
July 13, 2023 11:26
6729689
to
41d1151
Compare
radeusgd
requested review from
4e6,
JaroslavTulach,
hubertp and
Akirathan
as code owners
July 13, 2023 11:27
jdunkerley
approved these changes
Jul 13, 2023
radeusgd
force-pushed
the
wip/radeusgd/date-diff-add-for-scalars
branch
from
July 13, 2023 14:02
41d1151
to
49a5daf
Compare
4e6
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI: No changelog needed
Do not require a changelog entry for this PR.
CI: Ready to merge
This PR is eligible for automatic merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Followup of #7221, adding
date_diff
,date_add
anddate_part
to scalar Enso date-time values.Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.