Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add date_diff, date_add and date_part to scalar Enso date-time values. #7273

Merged
merged 11 commits into from
Jul 13, 2023

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Jul 12, 2023

Pull Request Description

Followup of #7221, adding date_diff, date_add and date_part to scalar Enso date-time values.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@radeusgd radeusgd added the CI: No changelog needed Do not require a changelog entry for this PR. label Jul 12, 2023
@radeusgd radeusgd self-assigned this Jul 12, 2023
@radeusgd radeusgd force-pushed the wip/radeusgd/date-diff-add-for-scalars branch from 6729689 to 41d1151 Compare July 13, 2023 11:26
@radeusgd radeusgd marked this pull request as ready for review July 13, 2023 11:27
Base automatically changed from wip/radeusgd/column-date-ops to develop July 13, 2023 12:56
@radeusgd radeusgd force-pushed the wip/radeusgd/date-diff-add-for-scalars branch from 41d1151 to 49a5daf Compare July 13, 2023 14:02
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Jul 13, 2023
@mergify mergify bot merged commit 620cc36 into develop Jul 13, 2023
25 of 26 checks passed
@mergify mergify bot deleted the wip/radeusgd/date-diff-add-for-scalars branch July 13, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants