Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement replace on the Database Column #7275

Merged
merged 45 commits into from
Jul 25, 2023
Merged

Implement replace on the Database Column #7275

merged 45 commits into from
Jul 25, 2023

Conversation

GregoryTravis
Copy link
Contributor

@GregoryTravis GregoryTravis commented Jul 12, 2023 •
edited
Loading

Pull Request Description

Implements replace for database text columns, for text, regex, and column patterns.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

radeusgd
radeusgd approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, let's ship it! 🚀 :shipit:

@GregoryTravis GregoryTravis added the CI: Ready to merge This PR is eligible for automatic merge label Jul 18, 2023
@GregoryTravis GregoryTravis removed the CI: Ready to merge This PR is eligible for automatic merge label Jul 19, 2023
@GregoryTravis GregoryTravis added the CI: Ready to merge This PR is eligible for automatic merge label Jul 19, 2023
@jdunkerley jdunkerley linked an issue Jul 25, 2023 that may be closed by this pull request
Implement replace on the Database Column #5160
Closed
@mergify mergify bot merged commit 1f6fcf1 into develop Jul 25, 2023
24 of 26 checks passed
@mergify mergify bot deleted the wip/gmt/5160-db-replace branch July 25, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radeusgd radeusgd radeusgd approved these changes

@jdunkerley jdunkerley jdunkerley approved these changes

Assignees
No one assigned
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement replace on the Database Column
3 participants
@GregoryTravis @radeusgd @jdunkerley