Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drop down for replace, remove Column_Selector #7295

Merged
merged 14 commits into from
Jul 14, 2023

Conversation

jdunkerley
Copy link
Member

@jdunkerley jdunkerley commented Jul 14, 2023

Pull Request Description

  • Add dropdowns for replace functions.
  • Retire Column_Selector type.
  • Add select_blank_columns and remove_blank_columns functions to table types.
  • Allow Regex to be used to pick columns.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@jdunkerley jdunkerley marked this pull request as ready for review July 14, 2023 11:00
Comment on lines +263 to +264
? Blank values
Blank values are `Nothing`, `""` and depending on setting `Number.nan`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like I'd sometimes want to distinguish between a "" and Nothing - depending on context these may have some different meaning - e.g. in database NULL vs empty string are different entries and they can mean different things.

Do you think we should add treat_empty_string_as_blank like treat_nan_as_blank?

I'm not strongly attached to it since this can be emulated relatively easily using more primitive operations. So whatever you think will be better.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was be design when we agreed the previous API design for removing blank values.

I appreciate there is a difference but the single value case can easily be done using the filter API.

Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and the usages look much cleaner with the new approach! ❤️

…ons.enso

Co-authored-by: GregoryTravis <greg.m.travis@gmail.com>
@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Jul 14, 2023
@mergify mergify bot merged commit aaa235f into develop Jul 14, 2023
24 of 25 checks passed
@mergify mergify bot deleted the wip/jd/comparison-operators branch July 14, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants