Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type checks inconsistent when dealing with a -> b function types #7298

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Type checks inconsistent when dealing with a -> b function types #7298

merged 2 commits into from
Jul 17, 2023

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Jul 15, 2023 •
edited
Loading

Pull Request Description

Test to check faulty behavior described in #7289 and a fix.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Scala,
    Java,
  • All code has been tested:
    • Unit tests have been written where possible.

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Jul 15, 2023
@JaroslavTulach JaroslavTulach self-assigned this Jul 15, 2023
@JaroslavTulach
Copy link
Member Author

JaroslavTulach commented Jul 15, 2023 •
edited
Loading

We have four failing test cases. Now we can fix them. Done in 9f18057

@JaroslavTulach JaroslavTulach linked an issue Jul 15, 2023 that may be closed by this pull request
Type checks inconsistent when dealing with a -> b function types #7289
Closed
@JaroslavTulach JaroslavTulach mentioned this pull request Jul 15, 2023
Closed
@JaroslavTulach JaroslavTulach merged commit e595130 into develop Jul 17, 2023
27 checks passed
@JaroslavTulach JaroslavTulach deleted the wip/jtulach/AscribedFunctionTypes_7289 branch July 17, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radeusgd radeusgd radeusgd approved these changes

@Akirathan Akirathan Akirathan approved these changes

@jdunkerley jdunkerley Awaiting requested review from jdunkerley jdunkerley is a code owner

@GregoryTravis GregoryTravis Awaiting requested review from GregoryTravis GregoryTravis is a code owner

@4e6 4e6 Awaiting requested review from 4e6 4e6 is a code owner

@hubertp hubertp Awaiting requested review from hubertp hubertp is a code owner

Assignees

@JaroslavTulach JaroslavTulach

Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type checks inconsistent when dealing with a -> b function types
3 participants
@JaroslavTulach @radeusgd @Akirathan