Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ResourceManagerTest to verify resources are cleaned on ctx.close() #7302

Merged
merged 4 commits into from
Jul 17, 2023
Merged

ResourceManagerTest to verify resources are cleaned on ctx.close() #7302

merged 4 commits into from
Jul 17, 2023

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Jul 17, 2023 •
edited
Loading

Pull Request Description

Demonstration of the ideal behavior of #6472 - the test seems to be working just fine.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Java,
  • All code has been tested:
    • Unit tests have been written where possible.

@JaroslavTulach JaroslavTulach added CI: Ready to merge This PR is eligible for automatic merge CI: No changelog needed Do not require a changelog entry for this PR. labels Jul 17, 2023
@JaroslavTulach JaroslavTulach self-assigned this Jul 17, 2023
@JaroslavTulach JaroslavTulach mentioned this pull request Jul 17, 2023
Closed
@JaroslavTulach JaroslavTulach linked an issue Jul 17, 2023 that may be closed by this pull request
Exception from ResourceManager at end of execution #6472
Closed
@mergify mergify bot merged commit a80f9d6 into develop Jul 17, 2023
23 of 24 checks passed
@mergify mergify bot deleted the wip/jtulach/ResourceManagerTest_6472 branch July 17, 2023 16:23
@enso-bot enso-bot bot mentioned this pull request Jul 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radeusgd radeusgd radeusgd approved these changes

@Akirathan Akirathan Akirathan approved these changes

@4e6 4e6 Awaiting requested review from 4e6 4e6 is a code owner

@hubertp hubertp Awaiting requested review from hubertp hubertp is a code owner

Assignees

@JaroslavTulach JaroslavTulach

Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception from ResourceManager at end of execution
3 participants
@JaroslavTulach @radeusgd @Akirathan