Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zone to Date_Times #7325

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Add zone to Date_Times #7325

merged 2 commits into from
Jul 19, 2023

Conversation

GregoryTravis
Copy link
Contributor

Pull Request Description

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@GregoryTravis GregoryTravis marked this pull request as ready for review July 18, 2023 17:30
Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, sorry I forgot about it.

We need to remember for future that any TZ-sensitive tests should specify the timezone and not rely too much on the defaults.

@jdunkerley
Copy link
Member

Great to iron this out.

@GregoryTravis GregoryTravis added the CI: No changelog needed Do not require a changelog entry for this PR. label Jul 18, 2023
@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Jul 19, 2023
@mergify mergify bot merged commit 8a82938 into develop Jul 19, 2023
27 of 29 checks passed
@mergify mergify bot deleted the wip/gmt/dst-test-failure branch July 19, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants