Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update junit-interface #7338

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Update junit-interface #7338

merged 2 commits into from
Jul 19, 2023

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented Jul 19, 2023

Pull Request Description

Fixes running Junit tests with SBT.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.

@4e6 4e6 added the CI: No changelog needed Do not require a changelog entry for this PR. label Jul 19, 2023
@4e6 4e6 self-assigned this Jul 19, 2023
@JaroslavTulach
Copy link
Member

I used to have a problem with:

sbt:runtime> testOnly *ErrorCompilerTest

not executing any tests inspite of ErrorCompilerTest beying there.

I don't have a feeling this PR fixes my problem.

@4e6
Copy link
Contributor Author

4e6 commented Jul 19, 2023

I checked. It works for me after the version bump

sbt:enso> runtime/testOnly *.ExecCompilerTest
[info] Passed: Total 5, Failed 0, Errors 0, Passed 5
[success] Total time: 11 s, completed Jul 19, 2023, 7:46:49 PM

JaroslavTulach
JaroslavTulach approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@JaroslavTulach JaroslavTulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After doing clean rm -rf *; git checkout -f . build, the upgrade seems to help. Thank you.

@4e6 4e6 added the CI: Ready to merge This PR is eligible for automatic merge label Jul 19, 2023
@mergify mergify bot merged commit fc37cb7 into develop Jul 19, 2023
24 of 26 checks passed
@mergify mergify bot deleted the wip/db/update-junit-interface branch July 19, 2023 19:07
@enso-bot enso-bot bot mentioned this pull request Jul 20, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaroslavTulach JaroslavTulach JaroslavTulach approved these changes

@hubertp hubertp Awaiting requested review from hubertp hubertp is a code owner

@Akirathan Akirathan Awaiting requested review from Akirathan Akirathan is a code owner

Assignees

@4e6 4e6

Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@4e6 @JaroslavTulach