Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky pending saves vcs test #7355

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Flaky pending saves vcs test #7355

merged 1 commit into from
Jul 20, 2023

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented Jul 20, 2023

Pull Request Description

Ensure force all pending saves does not fail.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.

@4e6 4e6 added the CI: No changelog needed Do not require a changelog entry for this PR. label Jul 20, 2023
@4e6 4e6 self-assigned this Jul 20, 2023
@4e6
Copy link
Contributor Author

4e6 commented Jul 20, 2023

Did a few re-runs today. It seems it does not trigger the issue anymore

@4e6 4e6 marked this pull request as ready for review July 20, 2023 15:46
@4e6 4e6 merged commit f69bf1b into develop Jul 20, 2023
26 of 28 checks passed
@4e6 4e6 deleted the wip/db/fix-vcs-test branch July 20, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaroslavTulach JaroslavTulach Awaiting requested review from JaroslavTulach JaroslavTulach is a code owner

@hubertp hubertp Awaiting requested review from hubertp hubertp is a code owner

@Akirathan Akirathan Awaiting requested review from Akirathan Akirathan is a code owner

Assignees

@4e6 4e6

Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@4e6