Update numeric benchmarks to jmh #7513
Conversation
lib/scala/bench-processor/src/main/java/org/enso/benchmarks/processor/BenchProcessor.java
Show resolved
Hide resolved
| all = Bench.build builder-> | ||
| builder.group "Numbers" options group_builder-> | ||
| collect_benches group_builder | ||
|
|
||
| all |
There was a problem hiding this comment.
| all = Bench.build builder-> | |
| builder.group "Numbers" options group_builder-> | |
| collect_benches group_builder | |
| all | |
| Bench.build builder-> | |
| builder.group "Numbers" options group_builder-> | |
| collect_benches group_builder |
| fun = pair.at 1 | ||
| IO.println <| "Benchmarking decimal " + name | ||
| Bench.measure (decimals.map fun) name iter_size num_iterations | ||
| IO.println <| "Benchmarking " + name |
There was a problem hiding this comment.
I think we need to get rid of such printlns, because they will start being printed also when only gathering benchmark structure.
| IO.println <| "Benchmarking " + name |
There was a problem hiding this comment.
Yes. I think that as well. They are, indeed, printed during the benchmark gathering.
There was a problem hiding this comment.
Another thing is that initialization which is relatively heavy also happens at the gathering step, slowing it down a bit.
But I don't think we have a good solution for this yet. I have an idea how we might do this, but I don't think it's in the scope of this PR.
There was a problem hiding this comment.
It's not in scope of this PR, but it might be in the scope of #7519
There was a problem hiding this comment.
The setup and teardown approaches related discussion is at #7519 (review)
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.