Use only Type instances as keys for State #7585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
requested review from
jdunkerley,
radeusgd,
GregoryTravis,
4e6,
hubertp and
Akirathan
as code owners
Akirathan
approved these changes
Aug 15, 2023
JaroslavTulach
commented
Aug 16, 2023
| @@ -158,23 +158,23 @@ optimize_fragments : Vector SQL_Fragment -> Vector SQL_Fragment | |||
| optimize_fragments fragments = | |||
| builder = Vector.new_builder | |||
| go elem = | |||
| last_part = State.get SQL_Fragment.Code_Part | |||
| last_part = State.get SQL_Fragment | |||
There was a problem hiding this comment.
Code_Part is an atom constructor - that's a singleton. We could allow atom constructors as keys, but then there is problem with argumentless constructors like Boolean.True - they are immediately converted to Atom during Enso execution and atoms in general aren't singletons.
Restricting keys to types is simpler.
JaroslavTulach
commented
Aug 16, 2023
| @@ -12,7 +12,7 @@ from project.Errors.Common import Uninitialized_State | |||
|
|
|||
| Arguments: | |||
| - key: The key to associate your local_state with in the environment. | |||
| It is recommended that types be used as keys. | |||
| Use types as keys. | |||
There was a problem hiding this comment.
The signature of run : Any -> Any -> Any -> Any remains unchanged, as we don't have any type for type Some_Type.
jdunkerley
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #7572 by requiring keys to be Type instances.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.