Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing generic Any.to type conversion method #7704

Merged
merged 6 commits into from Sep 1, 2023

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Aug 31, 2023

Pull Request Description

Provides Any.to conversion method. Such a method allows us finish #4821 - e.g. use Text.from instead of Text.to_text where possible. This method is a per-requisite of further work on

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • All code follows the
    Java,
  • All code has been tested:
    • Unit tests have been written where possible.

@JaroslavTulach
Copy link
Member Author

8a56db5 demonstrates the fix proposed in #4879 really works and Any.to conversion can accept additional optional arguments.


Complex.Value 3 4 . to Number

to : Any -> Any ! No_Such_Conversion
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently we get a PanicException with No_Such_Conversion atom as a payload when conversion isn't available. OK? Or do we prefer data flow error?

@enso-bot
Copy link

enso-bot bot commented Sep 1, 2023

Jaroslav Tulach reports a new STANDUP for yesterday (2023-08-31):

Progress: - Any.to: #7704

Next Day: Integrate Any.to. Bugfixing

Discord
Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.

@JaroslavTulach JaroslavTulach merged commit 1437a67 into develop Sep 1, 2023
25 checks passed
@JaroslavTulach JaroslavTulach deleted the wip/jtulach/AnyTo_7320 branch September 1, 2023 06:05
@enso-bot
Copy link

enso-bot bot commented Sep 2, 2023

Jaroslav Tulach reports a new STANDUP for yesterday (2023-09-01):

Progress: - Any.to merged: 58af199

Next Day: suggestion.db investigation

datapythonista blog
Introduction At the time of writing this post, we are in the process of releasing pandas 2.0. The project has a large number of users,...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants