Rename Decimal to Float #7807
Merged
Rename Decimal to Float #7807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubertp
requested review from
jdunkerley,
radeusgd,
GregoryTravis,
4e6,
JaroslavTulach,
Akirathan,
MichaelMauderer,
farmaazon,
kazcw,
vitvakatu,
Frizi and
mwu-tow
as code owners
radeusgd
approved these changes
Sep 13, 2023
| @@ -18,7 +18,7 @@ polyglot java import org.enso.base.polyglot.NumericConverter | |||
| most_specific_value_type : Any -> Boolean -> Value_Type | |||
| most_specific_value_type value use_smallest=False = | |||
| case value of | |||
| _ : Decimal -> Value_Type.Float Bits.Bits_64 | |||
| _ : Float -> Value_Type.Float Bits.Bits_64 | |||
There was a problem hiding this comment.
So good to see the Enso types and Value_Types finally consistent 😃
GregoryTravis
approved these changes
Sep 13, 2023
JaroslavTulach
approved these changes
Sep 14, 2023
...ime/src/bench/java/org/enso/interpreter/bench/benchmarks/semantic/TypePatternBenchmarks.java
Outdated
Show resolved
Hide resolved
engine/runtime/src/main/java/org/enso/interpreter/runtime/builtin/Number.java
Show resolved
Hide resolved
farmaazon
approved these changes
Sep 14, 2023
hubertp
force-pushed
the
wip/hubert/6889-decimal-to-float
branch
from
f7902d1
to
596fd89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Implements #6889.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.