Change filter_blank_rows when_any parameter to have a more user-friendly type #7935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cassandra-Clark
requested review from
jdunkerley,
radeusgd and
GregoryTravis
as code owners
GregoryTravis
approved these changes
Sep 29, 2023
distribution/lib/Standard/Database/0.0.0-dev/src/Data/Table.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Database/0.0.0-dev/src/Data/Table.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Database/0.0.0-dev/src/Data/Table.enso
Outdated
Show resolved
Hide resolved
test/Table_Tests/src/Common_Table_Operations/Missing_Values_Spec.enso
Outdated
Show resolved
Hide resolved
jdunkerley
previously requested changes
Oct 2, 2023
distribution/lib/Standard/Table/0.0.0-dev/src/Data/Blank_Selector.enso
Outdated
Show resolved
Hide resolved
test/Table_Tests/src/Common_Table_Operations/Missing_Values_Spec.enso
Outdated
Show resolved
Hide resolved
radeusgd
reviewed
Oct 2, 2023
distribution/lib/Standard/Table/0.0.0-dev/src/Internal/Table_Helpers.enso
Show resolved
Hide resolved
radeusgd
reviewed
Oct 2, 2023
Comment on lines
226
to
230
| col_aggregate = if when_any then Aggregate_Column.Maximum _ else Aggregate_Column.Minimum _ | ||
| col_aggregate = case when of | ||
| Blank_Selector.Any_Cell_Blank -> Aggregate_Column.Maximum | ||
| Blank_Selector.All_Cells_Blank -> Aggregate_Column.Minimum |
There was a problem hiding this comment.
Does this work without the _ underscores??
IIRC without the underscore this uses default values and creates a Aggregate_Column.Maximum 0 which will always check the first column. That will inevitably be incorrect once columns.length > 1.
Do the tests still succeed with that? If yes, I think we will need to expand the tests to ensure such an error is caught to avoid regressions.
There was a problem hiding this comment.
Shifted this to include _ underscores
Cassandra-Clark
force-pushed
the
7931-change-filter_blank_rows-when_any-parameter-to-have-a-more-user-friendly-type
branch
from
a2ba764
to
878823a
Compare
Added Blank_Selector constructor and applied to remove_blank_columns, select_blank_columns, filter_blank_rows
…tor.enso Co-authored-by: James Dunkerley <jdunkerley@users.noreply.github.com>
Co-authored-by: James Dunkerley <jdunkerley@users.noreply.github.com>
Added Blank_Selector constructor and applied to remove_blank_columns, select_blank_columns, filter_blank_rows
Cassandra-Clark
force-pushed
the
7931-change-filter_blank_rows-when_any-parameter-to-have-a-more-user-friendly-type
branch
from
253362a
to
e415a95
Compare
There were errors before as these weren't updated
jdunkerley
approved these changes
Nov 1, 2023
mergify
bot
deleted the
7931-change-filter_blank_rows-when_any-parameter-to-have-a-more-user-friendly-type
branch
radeusgd
reviewed
Nov 2, 2023
| @@ -196,14 +197,15 @@ type Table_Column_Helper | |||
| completely blank or have some blanks. | |||
|
|
|||
| Arguments: | |||
| - when_any: By default, only columns consisting of all blank cells are | |||
| selected. If set to `True`, columns with one or more blank values are | |||
| -TODO docs | |||
radeusgd
reviewed
Nov 2, 2023
| @@ -0,0 +1,6 @@ | |||
| ## TODO Documents | |||
There was a problem hiding this comment.
I think we should add a piece of docs here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Added Blank_Selector constructor and applied to remove_blank_columns, select_blank_columns, filter_blank_rows for #7931 . Changed when_any to when for readability.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR: